Skip to content

upload source archive before any rustwide tweaking of the crate #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
syphar merged 1 commit into from
Jan 22, 2026
Merged

upload source archive before any rustwide tweaking of the crate #3144

syphar merged 1 commit into from
Jan 22, 2026

Conversation

@syphar
Copy link
Member

@syphar syphar commented Jan 16, 2026 •
edited
Loading

Resolves #2655, Resolves #3136

  • move the source upload to before the rustwide prepare phase. ( rustwide will extract the source again )
  • the "rustwide tweaking" often referred to.
  • Also replaces the test-crate in one of the test-cases with a local one

@syphar syphar self-assigned this Jan 16, 2026
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Jan 16, 2026
@syphar syphar changed the title earlier source DRAFT / WIP: upload source archive before any rustwide tweaking of the crate Jan 16, 2026
@syphar syphar changed the title DRAFT / WIP: upload source archive before any rustwide tweaking of the crate upload source archive before any rustwide tweaking of the crate Jan 22, 2026
@syphar syphar marked this pull request as ready for review January 22, 2026 10:20
@syphar syphar requested a review from a team as a code owner January 22, 2026 10:20
@syphar syphar merged commit cf1182d into rust-lang:main Jan 22, 2026
14 checks passed
@syphar syphar deleted the earlier-source branch January 22, 2026 10:35
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Jan 22, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@syphar syphar

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

try to upload the source as early as possible Cargo.toml source rendered by docs.rs is inconsistent with Cargo.toml published by Cargo

2 participants

@syphar @GuillaumeGomez