Skip to content

extend security-middleware to also block encoded path traversal attempts #3141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
syphar merged 1 commit into from
Jan 16, 2026
Merged

extend security-middleware to also block encoded path traversal attempts #3141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions crates/bin/docs_rs_web/src/middleware/security.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,13 @@ pub(crate) async fn security_middleware(
req: AxumHttpRequest,
next: Next,
) -> AxumResponse {
let path = uri.path();

if let Err(err) = url_decode(path) {
warn!(%uri, ?err, "invalid UTF-8 in request path");
return StatusCode::NOT_ACCEPTABLE.into_response();
}
let path = match url_decode(uri.path()) {
Ok(path) => path,
Err(err) => {
warn!(%uri, ?err, "invalid UTF-8 in request path");
return StatusCode::NOT_ACCEPTABLE.into_response();
}
};

if path.contains("/../") || path.ends_with("/..") {
warn!(%uri, "detected path traversal attempt");
Expand All @@ -44,6 +45,7 @@ mod tests {
#[test_case("/../"; "relative path with slash")]
#[test_case("/.."; "relative path")]
#[test_case("/asdf/../"; "relative path 2")]
#[test_case("/tiny_http/latest/tiny_http%2f%2e%2e"; "encoded")]
async fn test_invalid_path(path: &str) -> Result<()> {
let app = Router::new()
.route("/{*inner}", get(|| async { StatusCode::OK }))
Expand Down
Loading