Skip to content

add packages necessary for containerd-shim-wasm to compile #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

Mossaka
Copy link
Contributor

@Mossaka Mossaka commented Nov 26, 2024

Added the missing libseccomp-dev package so that containerd-shim-wasm can build.

Related build failure: https://docs.rs/crate/containerd-shim-wasm/0.7.0/builds/1383467

@syphar
Copy link
Member

syphar commented Nov 27, 2024

Generally adding dependencies here is fine with me.

are you sure this is what solves your issue? Did you test it with https://forge.rust-lang.org/docs-rs/add-dependencies.html ?

Why I asking: the docs for libcontainer itself seems to work, the same way as the docs for libseccomp or libseccomp-sys.

@Mossaka
Copy link
Contributor Author

Mossaka commented Dec 6, 2024

are you sure this is what solves your issue? Did you test it with https://forge.rust-lang.org/docs-rs/add-dependencies.html ?

Ah yes, I've tested this by pull down the image ghcr.io/rust-lang/crates-build-env/linux:latest and tried compiling the project locally. I could produce the same error. After I added the missing package, I could build it successfully.

I have also tried following the steps in this document, but I was not able run this command:

$ docker-compose run \
    -e DOCSRS_DOCKER_IMAGE=ghcr.io/rust-lang/crates-build-env/linux-micro:latest \
    -e RUST_BACKTRACE=1 \
    -v "$YOUR_CRATE":/opt/rustwide/workdir \
    web build crate --local /opt/rustwide/workdir/crates/containerd-shim-wasm
    
 ...
DEBUG docbuilder.build_package{version="0.8.0" kind=Local("/opt/rustwide/workdir/crates/containerd-shim-wasm") krate="containerd-shim-wasm"}:update_build_with_error{build_id=BuildId(13) errors=Some("invalid Cargo.toml syntax\n\nStack backtrace:\n   0: from<rustwide::prepare::PrepareError>\n             at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.93/src/backtrace.rs:27:14\n   1: into<rustwide::prepare::PrepareError, anyhow::Error>\n  

I am not entirely sure what's the issue. I would appreciate if you could help me on this one!

Why I asking: the docs for libcontainer itself seems to work, the same way as the docs for libseccomp or libseccomp-sys.

This is indeed intriguing and I do not know the answer myself. CC @utam0k if you have even run into the same docs.rs build failure for libseccomp? I know that you are working on moving away from it with this work.

Copy link
Member

@syphar syphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test sounds fine with me, thank you for the contribution!

@syphar syphar merged commit 8798923 into rust-lang:master Dec 6, 2024
3 checks passed
@Mossaka
Copy link
Contributor Author

Mossaka commented Dec 12, 2024

Great! Could you please provide some instructions on how I can test this one out? Do I need to do another release and push to crates.io? 🙏 @syphar

@syphar
Copy link
Member

syphar commented Dec 12, 2024

Until a user can manual request rebuilds, a new release is the approach many people take.

You can also request rebuilds from us via ticket, which we then trigger on the server, which I just did. The rebuild also succeeded just now

@syphar
Copy link
Member

syphar commented Dec 12, 2024

just realized there is a newer version since this PR creation, triggered a rebuild for that one too.

@Mossaka
Copy link
Contributor Author

Mossaka commented Dec 12, 2024

Awesome!! Thanks so much 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants