-
Notifications
You must be signed in to change notification settings - Fork 101
add packages necessary for containerd-shim-wasm to compile #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Generally adding dependencies here is fine with me. are you sure this is what solves your issue? Did you test it with https://forge.rust-lang.org/docs-rs/add-dependencies.html ? Why I asking: the docs for |
Ah yes, I've tested this by pull down the image I have also tried following the steps in this document, but I was not able run this command: $ docker-compose run \
-e DOCSRS_DOCKER_IMAGE=ghcr.io/rust-lang/crates-build-env/linux-micro:latest \
-e RUST_BACKTRACE=1 \
-v "$YOUR_CRATE":/opt/rustwide/workdir \
web build crate --local /opt/rustwide/workdir/crates/containerd-shim-wasm
...
DEBUG docbuilder.build_package{version="0.8.0" kind=Local("/opt/rustwide/workdir/crates/containerd-shim-wasm") krate="containerd-shim-wasm"}:update_build_with_error{build_id=BuildId(13) errors=Some("invalid Cargo.toml syntax\n\nStack backtrace:\n 0: from<rustwide::prepare::PrepareError>\n at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/anyhow-1.0.93/src/backtrace.rs:27:14\n 1: into<rustwide::prepare::PrepareError, anyhow::Error>\n I am not entirely sure what's the issue. I would appreciate if you could help me on this one!
This is indeed intriguing and I do not know the answer myself. CC @utam0k if you have even run into the same docs.rs build failure for libseccomp? I know that you are working on moving away from it with this work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test sounds fine with me, thank you for the contribution!
Great! Could you please provide some instructions on how I can test this one out? Do I need to do another release and push to crates.io? 🙏 @syphar |
Until a user can manual request rebuilds, a new release is the approach many people take. You can also request rebuilds from us via ticket, which we then trigger on the server, which I just did. The rebuild also succeeded just now |
just realized there is a newer version since this PR creation, triggered a rebuild for that one too. |
Awesome!! Thanks so much 🙏 |
Added the missing
libseccomp-dev
package so that containerd-shim-wasm can build.Related build failure: https://docs.rs/crate/containerd-shim-wasm/0.7.0/builds/1383467