Skip to content

Conversation

@kurtjd
Copy link
Contributor

@kurtjd kurtjd commented Jan 4, 2026

Adds Target enum to Config to allow different behavior during parsing depending on CPU architecture. Specifically, for now this is used to make vendorSystickConfig optional (defaulting to false) for non-ARM targets.

This reuses the Target enum from svd2rust and ideally this could then be used in svd2rust, but I didn't want to copy over the serde cfgs since there isn't a serde feature for svd-parser so may just have to have this minor code duplication in the two crates.

Resolves #296

@kurtjd kurtjd requested a review from a team as a code owner January 4, 2026 05:40
@kurtjd
Copy link
Contributor Author

kurtjd commented Jan 4, 2026

CI failure seems to be unrelated to my changes. Looks like a dep needs a greater rustc version than is being used in CI?

@burrbull
Copy link
Member

burrbull commented Jan 4, 2026

try to add indexmap = "=2.11.4" to svd-encoder Cargo.toml

@kurtjd
Copy link
Contributor Author

kurtjd commented Jan 4, 2026

try to add indexmap = "=2.11.4" to svd-encoder Cargo.toml

Thanks, looks like it did the trick at least running cargo +1.70.0 check locally. Pushed another commit with that change.

@burrbull
Copy link
Member

burrbull commented Jan 4, 2026

cc @Emilgardis

@burrbull burrbull added this pull request to the merge queue Jan 5, 2026
Merged via the queue into rust-embedded:master with commit ce317cd Jan 5, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does vendorSystickConfig need to be required?

3 participants