-
Notifications
You must be signed in to change notification settings - Fork 235
Add asynchronous versions of most embedded-hal traits using GATs #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
e736fb5
First attempt at futures module
lachlansneff ff085fa
Fix some of the docs
lachlansneff 7eb5fd1
Add 'unstable-gats' feature to enable futures module
lachlansneff 3a30a33
Add async i2c module
lachlansneff d9d08fa
Remove futures::spi::FullDuplex
lachlansneff 1928f77
Make futures::spi::{Read, Write, ReadWrite, ReadWriteInPlace} traits
lachlansneff 5cdd987
Rename the futures feature to unstable-features
lachlansneff eecf646
Remove commented-out futures::spi::Transactional trait
lachlansneff 6298952
Remove MaybeUninit from futures::spi::ReadWriteInPlace
lachlansneff bac1603
Remove futures::i2c::Transactional and remove required min_type_alias…
lachlansneff 92aa33b
Remove some unncessary bounds from futures::spi traits
lachlansneff 582ebad
Return initialized buffers from method that read into an uninitialize…
lachlansneff a61008b
Update spi trait names
lachlansneff 306b187
Remove MaybeUninit from futures::spi
lachlansneff 92e0da4
Update changelog
lachlansneff 7ebd9c5
Merge branch 'master' into master
lachlansneff b79bf16
Expand the CHANGELOG.md addition
lachlansneff 4d02ea1
Add futures::Delay trait
lachlansneff 41af589
Add futures::digital::AsyncInputPin trait
lachlansneff 48ab3a8
Switch futures::Delay to take core::time::Duration and add futures::d…
lachlansneff 85accbd
Update changelog
lachlansneff eb2ff8a
Fix some docs in the futures module
lachlansneff d9174d2
Respond to feedback
lachlansneff 941c8bb
Change uart interface to read into a slice
lachlansneff 5617082
Mention what happens when the write and read slices in futures::spi::…
lachlansneff c002a23
Add more futures::digital traits
lachlansneff e686e6e
Change some associated future trait type names
lachlansneff 2e16b79
Formatting
lachlansneff 55cbca1
Remove MaybeUninit from futures::i2c
lachlansneff fee1b99
fix typo
lachlansneff 1df5604
Add error associated types to futures::digital traits
lachlansneff 38ba051
Expand names of generic associated future types
lachlansneff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,182 @@ | ||
//! Async I2C API | ||
//! | ||
//! This API supports 7-bit and 10-bit addresses. Traits feature an `AddressMode` | ||
//! marker type parameter. Two implementation of the `AddressMode` exist: | ||
//! `SevenBitAddress` and `TenBitAddress`. | ||
//! | ||
//! Through this marker types it is possible to implement each address mode for | ||
//! the traits independently in `embedded-hal` implementations and device drivers | ||
//! can depend only on the mode that they support. | ||
//! | ||
//! Additionally, the I2C 10-bit address mode has been developed to be fully | ||
//! backwards compatible with the 7-bit address mode. This allows for a | ||
//! software-emulated 10-bit addressing implementation if the address mode | ||
//! is not supported by the hardware. | ||
//! | ||
//! Since 7-bit addressing is the mode of the majority of I2C devices, | ||
//! `SevenBitAddress` has been set as default mode and thus can be omitted if desired. | ||
|
||
use core::future::Future; | ||
pub use crate::blocking::i2c::{AddressMode, SevenBitAddress, TenBitAddress, Operation}; | ||
|
||
/// Async read | ||
pub trait Read<A: AddressMode = SevenBitAddress> { | ||
/// Error type | ||
type Error; | ||
/// The future associated with the `read` method. | ||
type ReadFuture<'a>: Future<Output = Result<(), Self::Error>> + 'a | ||
where | ||
Self: 'a; | ||
|
||
/// Reads enough bytes from slave with `address` to fill `buffer` | ||
/// | ||
/// # I2C Events (contract) | ||
/// | ||
/// ``` text | ||
/// Master: ST SAD+R MAK MAK ... NMAK SP | ||
/// Slave: SAK B0 B1 ... BN | ||
/// ``` | ||
/// | ||
/// Where | ||
/// | ||
/// - `ST` = start condition | ||
/// - `SAD+R` = slave address followed by bit 1 to indicate reading | ||
/// - `SAK` = slave acknowledge | ||
/// - `Bi` = ith byte of data | ||
/// - `MAK` = master acknowledge | ||
/// - `NMAK` = master no acknowledge | ||
/// - `SP` = stop condition | ||
fn read<'a>(&'a mut self, address: A, buffer: &'a mut [u8]) -> Self::ReadFuture<'a>; | ||
} | ||
|
||
/// Async write | ||
pub trait Write<A: AddressMode = SevenBitAddress> { | ||
/// Error type | ||
type Error; | ||
/// The future associated with the `write` method. | ||
type WriteFuture<'a>: Future<Output = Result<(), Self::Error>> + 'a | ||
where | ||
Self: 'a; | ||
|
||
/// Writes bytes to slave with address `address` | ||
/// | ||
/// # I2C Events (contract) | ||
/// | ||
/// ``` text | ||
/// Master: ST SAD+W B0 B1 ... BN SP | ||
/// Slave: SAK SAK SAK ... SAK | ||
/// ``` | ||
/// | ||
/// Where | ||
/// | ||
/// - `ST` = start condition | ||
/// - `SAD+W` = slave address followed by bit 0 to indicate writing | ||
/// - `SAK` = slave acknowledge | ||
/// - `Bi` = ith byte of data | ||
/// - `SP` = stop condition | ||
fn write<'a>(&'a mut self, address: A, bytes: &'a [u8]) -> Self::WriteFuture<'a>; | ||
} | ||
|
||
/// Async write + read | ||
pub trait WriteRead<A: AddressMode = SevenBitAddress> { | ||
/// Error type | ||
type Error; | ||
/// The future associated with the `write_read` method. | ||
type WriteReadFuture<'a>: Future<Output = Result<(), Self::Error>> + 'a | ||
where | ||
Self: 'a; | ||
|
||
/// Writes bytes to slave with address `address` and then reads enough bytes to fill `buffer` *in a | ||
/// single transaction* | ||
/// | ||
/// # I2C Events (contract) | ||
/// | ||
/// ``` text | ||
/// Master: ST SAD+W O0 O1 ... OM SR SAD+R MAK MAK ... NMAK SP | ||
/// Slave: SAK SAK SAK ... SAK SAK I0 I1 ... IN | ||
/// ``` | ||
/// | ||
/// Where | ||
/// | ||
/// - `ST` = start condition | ||
/// - `SAD+W` = slave address followed by bit 0 to indicate writing | ||
/// - `SAK` = slave acknowledge | ||
/// - `Oi` = ith outgoing byte of data | ||
/// - `SR` = repeated start condition | ||
/// - `SAD+R` = slave address followed by bit 1 to indicate reading | ||
/// - `Ii` = ith incoming byte of data | ||
/// - `MAK` = master acknowledge | ||
/// - `NMAK` = master no acknowledge | ||
/// - `SP` = stop condition | ||
fn write_read<'a>( | ||
&'a mut self, | ||
address: A, | ||
bytes: &'a [u8], | ||
buffer: &'a mut [u8], | ||
) -> Self::WriteReadFuture<'a>; | ||
} | ||
|
||
/// Transactional I2C interface. | ||
/// | ||
/// This allows combining operations within an I2C transaction. | ||
pub trait Transactional<A: AddressMode = SevenBitAddress> { | ||
/// Error type | ||
type Error; | ||
/// The future associated with the `exec` method. | ||
type ExecFuture<'a>: Future<Output = Result<(), Self::Error>> + 'a | ||
where | ||
Self: 'a; | ||
|
||
/// Execute the provided operations on the I2C bus. | ||
/// | ||
/// Transaction contract: | ||
/// - Before executing the first operation an ST is sent automatically. This is followed by SAD+R/W as appropriate. | ||
/// - Data from adjacent operations of the same type are sent after each other without an SP or SR. | ||
/// - Between adjacent operations of a different type an SR and SAD+R/W is sent. | ||
/// - After executing the last operation an SP is sent automatically. | ||
/// - If the last operation is a `Read` the master does not send an acknowledge for the last byte. | ||
/// | ||
/// - `ST` = start condition | ||
/// - `SAD+R/W` = slave address followed by bit 1 to indicate reading or 0 to indicate writing | ||
/// - `SR` = repeated start condition | ||
/// - `SP` = stop condition | ||
fn exec<'a>(&'a mut self, address: A, operations: &'a mut [Operation<'a>]) | ||
-> Self::ExecFuture<'a>; | ||
} | ||
|
||
/// Default implementation of `futures::i2c::Transactional` for `futures::i2c::{Read, Write}` implementers. | ||
/// | ||
/// If you implement `futures::i2c::Read` and `futures::i2c::Write` for your I2C peripheral, | ||
/// you can use this default implementation so to automatically implement | ||
/// `futures::i2c::Transactional` as well. | ||
pub mod transactional { | ||
use super::{Future, AddressMode, Operation, Read, Transactional, Write}; | ||
|
||
/// Default implementation of `futures::i2c::Write`, `futures::i2c::Read` and | ||
/// `futures::i2c::WriteRead` traits for `futures::i2c::Transactional` implementers. | ||
pub trait Default<A: AddressMode>: Read<A> + Write<A> {} | ||
|
||
impl<A, E, S> Transactional<A> for S | ||
where | ||
A: AddressMode + Copy + 'static, | ||
S: Default<A> + Read<A, Error = E> + Write<A, Error = E>, | ||
E: 'static, | ||
{ | ||
type Error = E; | ||
|
||
type ExecFuture<'a> where Self: 'a = impl Future<Output = Result<(), Self::Error>> + 'a; | ||
|
||
fn exec<'a>(&'a mut self, address: A, operations: &'a mut [Operation<'a>]) -> Self::ExecFuture<'a> { | ||
async move { | ||
for op in operations { | ||
match op { | ||
Operation::Read(buffer) => self.read(address, buffer).await?, | ||
Operation::Write(buffer) => self.write(address, buffer).await?, | ||
} | ||
} | ||
|
||
Ok(()) | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.