Skip to content

[5.3] note a bug that makes completing the section difficult#55

Merged
adamgreig merged 2 commits intorust-embedded:mainfrom
ziyadedher:patch-1
Jul 20, 2025
Merged

[5.3] note a bug that makes completing the section difficult#55
adamgreig merged 2 commits intorust-embedded:mainfrom
ziyadedher:patch-1

Conversation

@ziyadedher
Copy link
Copy Markdown
Contributor

This commit highlights #27 in the tutorial directly and gives users a workaround.

This commit highlights rust-embedded#27 in the tutorial directly and gives users a workaround.
chapter in Rust Book] for more.

> **NOTE** If `cargo-embed` prints a lot of warnings here don't worry about it. As of now it does
> **NOTE**: If `cargo-embed` prints a lot of warnings here don't worry about it. As of now it does
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention in this book is to leave the colon : off. I agree that it's a bit janky, but it's everywhere.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pattern matched from this file and didn't take a look at the rest, but this file mostly has the with-colon version! Will change, though.

> Remote debugging using :1337
> init::__cortex_m_rt_main () at mdbook/src/05-meet-your-software/examples/init.rs:19
> 19 asm::nop();
> ```
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not seeing the actual monitor reset halt in this terminal fragment?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in!

Copy link
Copy Markdown
Member

@BartMassey BartMassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for this. We'll take it if — and only if — you pinky-promise to submit another PR to remove it once probe-rs is fixed 😀 .

Please see some notes about needed changes I've stuck in.

@ziyadedher
Copy link
Copy Markdown
Contributor Author

Addressed the feedback and yeah, I'll keep an eye out :P

I might forget, feel free to tag me in and I can PR it back out. If you'd prefer to keep this PR out though, for whatever reason, feel free; I have the info in my brain now haha.

Copy link
Copy Markdown
Member

@BartMassey BartMassey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol. Just did a grep and realized that there's more variance in the NOTEs that I remembered. This is good, though: thanks for catching the ones in this chapter.

@ziyadedher
Copy link
Copy Markdown
Contributor Author

(im unable to merge this myself btw!)

@BartMassey
Copy link
Copy Markdown
Member

Yes, waiting for another rust-embedded person to glance at it and merge it. If it doesn't happen soon, I'll merge it myself, but always nice to get an extra set of eyeballs.

Copy link
Copy Markdown
Member

@adamgreig adamgreig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@adamgreig adamgreig merged commit a8a16ac into rust-embedded:main Jul 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants