ci: drop nightly test checks, add bisect-ability#87
Open
nyonson wants to merge 1 commit intorust-bitcoin:masterfrom
Open
ci: drop nightly test checks, add bisect-ability#87nyonson wants to merge 1 commit intorust-bitcoin:masterfrom
nyonson wants to merge 1 commit intorust-bitcoin:masterfrom
Conversation
4a11b35 to
e7fd4cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the waters with this one.
--baselinearg to thetestcommand so tests are run on every commit of a PR, enforcing bisect-ability. The funky{{ github.event.pull_request.base.sha || github.event.before }}arg is a github-ism so that the command works both pre-merge and post-merge intomaster.nightlycompiler from thetestmatrix. I might be missing something, but I don't think thenightlytests are very valuable. We are runninglinton nightly, so there is still a high chance we will hear about a breaking change early on. But let me know if this is a bad assumption.