fix: use ideographic spaces for Japanese mnemonics#90
Open
ethicnology wants to merge 2 commits intorust-bitcoin:masterfrom
Open
fix: use ideographic spaces for Japanese mnemonics#90ethicnology wants to merge 2 commits intorust-bitcoin:masterfrom
ethicnology wants to merge 2 commits intorust-bitcoin:masterfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I noticed that when generating a Japanese mnemonic, the output sentence does not use ideographic spaces, and the library is unable to parse it correctly while they are recommended in bip39 Japanese section
I've also added some test vectors used for Japanese mnemonics