Refactoring for magnus integration and multiple output formats#54
Merged
Refactoring for magnus integration and multiple output formats#54
Conversation
perryqh
force-pushed
the
ph/setupforlib
branch
from
eb389f8 to
462a687
Compare
jackboberg
approved these changes
Feb 28, 2025
Contributor
jackboberg
left a comment
jackboberg
left a comment
There was a problem hiding this comment.
Makes sense to me. Nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change?
Printing to standard out inline is an anti-pattern because display logic shouldn't live with business logic.
We are potentially going to support a JSON output flag and magnus integration for ruby.
What?
Introduces a new result type containing error and info message vectors