Catch RenderXXX functions in UI #4338
Open
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cpsievert
reviewed
Dec 16, 2025
Comment on lines
+331
to
+335
| # return an error when render functions are used in UI | ||
| if (is.null(getDefaultReactiveDomain())) { | ||
| stop("There is a renderXXX function in the UI, these should only be used in the server function.", | ||
| "Use the corresponding XXXOutput function in the UI instead.") | ||
| } |
Collaborator
There was a problem hiding this comment.
Shoot, sorry. I gave bad advice in #4189. We can't throw an error in this case -- if we do, we'll break renderXXX() usage inside of R Markdown. Unfortunately, I'm not sure there's sensible approach to throwing this error 😞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally adding a suggestion to fix #4189 after doing this for the umpteenth time.
It would be nice if we could specify the file or module containing the problematic render function, but I am not sure how to do it.