move variable resettting to periodics #218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auscompgeek
reviewed
Apr 28, 2025
magicbot/magicrobot.py
Outdated
| @@ -729,6 +729,9 @@ def _do_periodics(self) -> None: | |||
| self.onException() | |||
| else: | |||
| setter(value) | |||
|
|
|||
| for reset_dict, component in self._reset_components: | |||
| component.__dict__.update(reset_dict) | |||
|
|
|||
| watchdog.addEpoch("@magicbot.feedback") | |||
|
|
|||
There was a problem hiding this comment.
I probably should've written a test for this, but this PR as proposed reintroduces what I considered a bug: the will_reset_to attributes shouldn't reset before robotPeriodic is called, since it can be useful to observe its value there, e.g. for logging.
There was a problem hiding this comment.
moved the thing after all periodics
LucienMorey
force-pushed
the
handle_resettables_in_test
branch
from
6e261f2 to
d15cd42
Compare
auscompgeek
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this technically fits the docs better for something that resets after every control cycle better than it only happening in teleop and auto. Maybe there is a case in which people don't want this to run in disabled but I cant think of what it might be off the top of my head. I can probably make a test for this calling
do_periodicslike intest_magicbot_feedback.pyis there any value in making it more complicated to check that it does the bits in all modes? rather than just doing it on periodic?