Don't allow keywords 'ID' and 'name' as port name

Piruri · Piruri · commit 37d1c996ecae · 2021-08-13T11:46:33.000+02:00
diff --git a/include/behaviortree_cpp_v3/basic_types.h b/include/behaviortree_cpp_v3/basic_types.h
@@ -265,6 +265,9 @@ std::pair<std::string,PortInfo> CreatePort(PortDirection direction,
                                            StringView name,
                                            StringView description = {})
 {
+    // Don't allow to create "ID" and "name" ports
+    if (name == "name" || name == "ID") { throw std::runtime_error {"Reserved port keys: \"name\" or \"ID\"! Cannot create port!"}; }
+
     std::pair<std::string,PortInfo> out;
 
     if( std::is_same<T, void>::value)

Original file line number	Diff line number	Diff line change
`@@ -265,6 +265,9 @@ std::pair<std::string,PortInfo> CreatePort(PortDirection direction,`
`265`	`265`	`StringView name,`
`266`	`266`	`StringView description = {})`
`267`	`267`	`{`
	`268`	`+ // Don't allow to create "ID" and "name" ports`
	`269`	`+ if (name == "name" \|\| name == "ID") { throw std::runtime_error {"Reserved port keys: \"name\" or \"ID\"! Cannot create port!"}; }`
	`270`	`+`
`268`	`271`	`std::pair<std::string,PortInfo> out;`
`269`	`272`
`270`	`273`	`if( std::is_same<T, void>::value)`