setInterval will clear itself when element is removed from the DOM#98
Open
scotthovestadt wants to merge 3 commits intormm5t:masterfrom
Open
setInterval will clear itself when element is removed from the DOM#98scotthovestadt wants to merge 3 commits intormm5t:masterfrom
scotthovestadt wants to merge 3 commits intormm5t:masterfrom
Conversation
setInterval will clear itself when element is removed from the DOM.
Credit to tangphillip.
|
Any word on this issue? Single page apps are becoming more common and timeago needs the ability to remove itself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My use-case is an activity feed with only 5 items. However, over the lifetime of the web application, thousands of items pass through the feed.
It was not ideal to have thousands of setInterval calls fire each minute.