Improving l10n-ability by adding callbacks for numbers and formatter#34
Open
deceze wants to merge 2 commits intormm5t:masterfrom
Open
Improving l10n-ability by adding callbacks for numbers and formatter#34deceze wants to merge 2 commits intormm5t:masterfrom
deceze wants to merge 2 commits intormm5t:masterfrom
Conversation
added 2 commits
February 10, 2011 13:33
… adding formatter callback
|
+1 for this, really useful for Japanese and Chinese. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing
jQuery.timeago.settings.strings.numbersto be a callback function and adding optionaljQuery.timeago.settings.strings.formattercallback, which can be used as a general post processing callback instead of the default$.trim([prefix, words, suffix].join(" ")).This allows 100% localized Japanese for example:
Returns
二十六日ほど前for "about 26 days ago".