fix(agent-adapters): robustness fixes to pi + claude ACP adapters#136
Merged
NathanFlurry merged 1 commit intoJun 26, 2026
Conversation
Five verified fixes to the Pi and Claude ACP agent adapters (each with a unit
test), found via a multi-agent review:
- claude: tool-permission handler no longer auto-resolves on a 2s timer (was
fail-open: ran the guest's tool without host consent); host is authoritative.
- claude: partial tool input attributed by streaming content-block index, not
Map insertion order.
- claude: a dead query reader marks the session closed so the next prompt()
fails fast instead of hanging to the ACP timeout.
- pi: live session subscription is torn down on replace + conn.closed;
editSnapshots cleared per turn + on cancel.
- pi + claude: failed session/update writes are logged to stderr instead of
silently swallowed (emit chain kept alive).
Tests: registry/agent/{claude,pi}/tests/adapter.test.mjs. No auto-resolve on
timeout remains in any adapter.
Member
Author
|
Stack for rivet-dev/secure-exec
Get stack: |
railway-app
Bot
temporarily deployed
to
secure-exec / secure-exec-pr-136
railway-app
Bot
temporarily deployed
to
rivet-frontend / secure-exec-pr-136
railway-app
Bot
requested a deployment
to
rivet-frontend / rivet-pr-5343
NathanFlurry
deleted the
stack/fix-agent-adapters-robustness-fixes-to-pi-claude-acp-adapters-spxuxyuy
branch
railway-app
Bot
requested a deployment
to
rivet-frontend / rivet-pr-5314
railway-app
Bot
requested a deployment
to
rivet-frontend / rivet-pr-5328
railway-app
Bot
requested a deployment
to
rivet-frontend / agentos-pr-1536
railway-app
Bot
requested a deployment
to
rivet-frontend / agentos-pr-1507
railway-app
Bot
requested a deployment
to
rivet-frontend / rivet-pr-5333
railway-app
Bot
requested a deployment
to
rivet-frontend / agentos-pr-1510
railway-app
Bot
requested a deployment
to
rivet-frontend / rivet-pr-5324
railway-app
Bot
requested a deployment
to
rivet-frontend / rivet-pr-5338
railway-app
Bot
requested a deployment
to
rivet-frontend / rivet-pr-5320
railway-app
Bot
requested a deployment
to
rivet-frontend / rivet-pr-5344
railway-app
Bot
requested a deployment
to
rivet-frontend / agentos-pr-1546
railway-app
Bot
requested a deployment
to
rivet-frontend / agentos-pr-1547
railway-app
Bot
requested a deployment
to
rivet-frontend / agentos-pr-1551
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five verified fixes to the Pi and Claude ACP agent adapters (each with a unit
test), found via a multi-agent review:
fail-open: ran the guest's tool without host consent); host is authoritative.
Map insertion order.
fails fast instead of hanging to the ACP timeout.
editSnapshots cleared per turn + on cancel.
silently swallowed (emit chain kept alive).
Tests: registry/agent/{claude,pi}/tests/adapter.test.mjs. No auto-resolve on
timeout remains in any adapter.