Skip to content

Add bitmask for Q #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025
Merged

Add bitmask for Q #107

merged 1 commit into from
Jun 5, 2025

Conversation

el-ev
Copy link
Contributor

@el-ev el-ev commented May 13, 2025

Q is the standard extension for Quad-precision floating point.
llvm/llvm-project#139369 is going to add assembly support for the Q extension.

https://github.com/riscv/riscv-isa-manual/blob/main/src/machine.adoc

Signed-off-by: Iris Shi <[email protected]>
@topperc
Copy link
Contributor

topperc commented May 13, 2025

binutils already has assembler support. Why does LLVM adding it require a new feature bit if binutils didn't?

@el-ev
Copy link
Contributor Author

el-ev commented May 15, 2025

binutils already has assembler support. Why does LLVM adding it require a new feature bit if binutils didn't?

The Q extension is a ratified standard extension and is assigned to the 17th bit. As it is getting supported by both projects I think it's a good time to add the bitmask.

@lenary
Copy link
Contributor

lenary commented Jun 3, 2025

@topperc We've stated the single letter extensions will match their bits in misa so we should just go ahead and add definitions here for all of the single letter extensions that exist. It's not clear to me why they weren't in the first place, or why we wouldn't do that anyway.

Yes not all of these are exposed through hwcaps on linux yet, and we do not have full compiler support, but surely the single-letter stuff we can proceed with?

Copy link
Contributor

@topperc topperc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenary lenary mentioned this pull request Jun 3, 2025
@cmuellner cmuellner merged commit 38fbfe1 into riscv-non-isa:main Jun 5, 2025
2 checks passed
@el-ev el-ev deleted the patch-1 branch June 6, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants