Skip to content

feat!: backport breaking changes from #479#482

Merged
antalsz merged 4 commits into456-feat-merge-cratesfrom
478-backport-breaking-changes
Sep 26, 2025
Merged

feat!: backport breaking changes from #479#482
antalsz merged 4 commits into456-feat-merge-cratesfrom
478-backport-breaking-changes

Conversation

@antalsz
Copy link
Contributor

@antalsz antalsz commented Sep 25, 2025

This PR backports the following breaking changes from #479, as they're generally useful for #462 and we want to minimize the number of breaking change releases. The changes are as follows

  1. Deleting the unused-but-public quil_rs::program::MemoryAccess type.
  2. Renaming the Calibration type to CalibrationDefinition for consistency, along with some updates to associated code.
  3. Fixing the MeasureCalibrationDefinition type to correctly have a required qubit and an optional memory address, rather than the other way around.
  4. Regenerating all the test files – not technically a breaking change, but very noisy. However, it gets things into a consistent state and deletes some .snap files that no longer correspond to anything, so it needed to happen.

Previously, `MeasureCalibrationDefinition` contained an *optional* qubit and
a *mandatory* memory address, rather than the other way around.
@windsurf-bot
Copy link

windsurf-bot bot commented Sep 25, 2025

This PR has too many files to review (>50 files).

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

PR Preview Action v1.6.2
Preview removed because the pull request was closed.
2025-09-26 17:54 UTC

Copy link
Contributor

@asaites asaites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@antalsz antalsz merged commit 7f547d2 into 456-feat-merge-crates Sep 26, 2025
18 checks passed
@antalsz antalsz deleted the 478-backport-breaking-changes branch September 26, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants