-
Notifications
You must be signed in to change notification settings - Fork 694
fixing autosilder on ng-repeat items #186
base: master
Are you sure you want to change the base?
Conversation
|
What is stopping this from getting merged in? |
|
just some time to review, rebase and merge, sorry :/ will dive into these days |
|
great news but no need for apologies :). Just asking to see if I could help. keep up the good work |
|
refactoring to apply review comments |
|
Anything I can do to help speed up the merge of this PR? |
|
Just as an FYI I've managed to fix this by moving the slideCount calculation into the increment function itself instead of globally. Not sure if this is a better solution than the one proposed in this pull just thought I'd share how I got this working. Not sure how cheap/expensive the element.children().length to call on each increment, but this seems a very straight forward one-liner fix and worked for me. |
|
hi |
adds
scope.$emit('rnCarousel:CollectionUpdated', slidesCount);on repeat collection changes so other directive can listen to itadds handle to
rnCarousel:CollectionUpdatedtorn-carousel-auto-slideto update the private count of slidesfixes #184