Skip to content

Fix rewatch panic on duplicate module name #8102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cknitt merged 6 commits into from
Dec 25, 2025
+226 −203
Merged

Fix rewatch panic on duplicate module name #8102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50467ae
Fix rewatch panic on duplicate module name
cknitt Dec 23, 2025
e1598f0
Deterministic order of file/module names in error message
cknitt Dec 24, 2025
a288fd1
Update rewatch/src/build/packages.rs
cknitt Dec 24, 2025
d1c46ec
Fix snapshot
cknitt Dec 24, 2025
fd59a19
Move cloning root_path into error handling code
cknitt Dec 25, 2025
8e05b8a
CHANGELOG
cknitt Dec 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
- Fix: do not warn for "editor" field in `rescript.json`. https://github.com/rescript-lang/rescript/pull/8084
- Fix `@val` shadowing (rewrite using `globalThis`). https://github.com/rescript-lang/rescript/pull/8098
- Fix `@scope` shadowing (rewrite using `globalThis`). https://github.com/rescript-lang/rescript/pull/8100
- Fix rewatch panic on duplicate module name. https://github.com/rescript-lang/rescript/pull/8102

#### :memo: Documentation

Expand Down
2 changes: 1 addition & 1 deletion rewatch/src/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ pub fn initialize_build(
}

let mut build_state = BuildCommandState::new(project_context, packages, compiler, warn_error);
packages::parse_packages(&mut build_state);
packages::parse_packages(&mut build_state)?;

let compile_assets_state = read_compile_state::read(&mut build_state)?;

Expand Down
2 changes: 1 addition & 1 deletion rewatch/src/build/clean.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ pub fn clean(path: &Path, show_progress: bool, plain_output: bool) -> Result<()>

let timing_clean_mjs = Instant::now();
let mut build_state = BuildState::new(project_context, packages, compiler_info);
packages::parse_packages(&mut build_state);
packages::parse_packages(&mut build_state)?;
let root_config = build_state.get_root_config();
let suffix_for_print = match root_config.package_specs {
None => match &root_config.suffix {
Expand Down
Loading
Loading