Skip to content

Make React.component conversion function zero cost #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2022
Merged

Make React.component conversion function zero cost #78

merged 1 commit into from
Oct 26, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 26, 2022

No description provided.

@cknitt cknitt requested a review from mununki October 26, 2022 16:33
mununki
mununki approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@mununki mununki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cristianoc
cristianoc approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally check in the build artifacts. No change here?

@cknitt
Copy link
Member Author

cknitt commented Oct 26, 2022

React.bs.js diff is there, Github just hides it by default.

@cknitt cknitt merged commit 16b3f37 into master Oct 26, 2022
@cknitt cknitt deleted the more-zero-cost branch October 26, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

@mununki mununki mununki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cknitt @cristianoc @mununki