Skip to content

Conversation

viceice
Copy link
Member

@viceice viceice commented Jul 24, 2025

Changes

Replace the kbpgp with the gnupg cli.
It's a little slower than the js variant.

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested review from rarkins and secustor July 24, 2025 14:23
@viceice viceice added ci:allow-undesirable Skip the undesirable files CI check and removed ci:allow-undesirable Skip the undesirable files CI check labels Jul 24, 2025
Can maybe happen on windows when temp is pointing to a path with whitespace.
secustor
secustor previously approved these changes Jul 25, 2025
Copy link
Contributor

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to decide if this is breaking or not

@rarkins rarkins changed the title feat(config): replace kbpgp with gnupg feat(config): replace kbpgp with gpg CLI Aug 12, 2025
Copy link
Contributor

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a breaking change and bump a major release?

@rarkins rarkins changed the title feat(config): replace kbpgp with gpg CLI feat(config)!: replace kbpgp with gpg CLI Aug 13, 2025
@viceice viceice added the breaking Breaking change, requires major version bump label Aug 14, 2025
@viceice viceice added this to the v42 milestone Aug 14, 2025
"@pnpm/parse-overrides": "1001.0.2",
"@qnighy/marshal": "0.1.3",
"@renovatebot/detect-tools": "1.1.0",
"@renovatebot/kbpgp": "4.0.1",
Copy link
Contributor

@jamietanna jamietanna Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth then deprecating this library? Looks like it's only Renovate using it: https://deps.dev/npm/%40renovatebot%2Fkbpgp/4.0.3/dependents

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but i'm thinking of using https://github.com/renovatebot/pgp (dotnet wasm variant) instead of the cli 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking change, requires major version bump

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace openpgp with gpg cli

5 participants