-
Notifications
You must be signed in to change notification settings - Fork 2.8k
feat(config)!: replace kbpgp
with gpg
CLI
#37147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Can maybe happen on windows when temp is pointing to a path with whitespace.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to decide if this is breaking or not
kbpgp
with gnupg
kbpgp
with gpg
CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make this a breaking change and bump a major release?
kbpgp
with gpg
CLIkbpgp
with gpg
CLI
"@pnpm/parse-overrides": "1001.0.2", | ||
"@qnighy/marshal": "0.1.3", | ||
"@renovatebot/detect-tools": "1.1.0", | ||
"@renovatebot/kbpgp": "4.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth then deprecating this library? Looks like it's only Renovate using it: https://deps.dev/npm/%40renovatebot%2Fkbpgp/4.0.3/dependents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, but i'm thinking of using https://github.com/renovatebot/pgp (dotnet wasm variant) instead of the cli 🤔
Changes
Replace the
kbpgp
with thegnupg
cli.It's a little slower than the js variant.
Context
openpgp
with gpg cli #30011Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: