Skip to content

Conversation

rarkins
Copy link
Contributor

@rarkins rarkins commented Jun 1, 2025

Changes

Refactors getNewValue logic to replace it with an optional getPinnedValue() where rangeStrategy=pin. This way each versioning module doesn't need to add and test extensive "pin" logic.

Context

Refactor prior to restoring pinVersions logic.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins requested review from secustor and viceice June 1, 2025 09:34
@rarkins
Copy link
Contributor Author

rarkins commented Jun 1, 2025

I noticed something curious: with go.mod values, it's impossible to pin to a version, so I was wondering how rangeStrategy=pin worked for it. Turns out we use semver versioning so everything looks like an exact version already and doesn't need pinning.

@rarkins rarkins requested a review from viceice June 4, 2025 08:33
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside the open question

@rarkins rarkins enabled auto-merge June 20, 2025 15:12
@rarkins
Copy link
Contributor Author

rarkins commented Aug 16, 2025

Let's merge in v42

@viceice viceice added this to the v42 milestone Aug 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants