-
Notifications
You must be signed in to change notification settings - Fork 2.8k
refactor: remove rangeStrategy=pin from versioning modules #36261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I noticed something curious: with go.mod values, it's impossible to pin to a version, so I was wondering how rangeStrategy=pin worked for it. Turns out we use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM beside the open question
Let's merge in v42 |
Changes
Refactors getNewValue logic to replace it with an optional getPinnedValue() where rangeStrategy=pin. This way each versioning module doesn't need to add and test extensive "pin" logic.
Context
Refactor prior to restoring
pinVersions
logic.Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: