Skip to content

Upgrade prettier #13916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from
Draft

Upgrade prettier #13916

wants to merge 3 commits into from

Conversation

brophdawg11
Copy link
Contributor

Trying to upgrade prettier to support import ... with syntax - we had to ignore an RSC integration file in 78b374b because it was breaking the format workflow.

Upgrading was simple, and it causes bunch of changes which seem harmless. I did have to set trailingComma:es5 to get the minimal set of changes (~100 files instead of 400-500 with the new default all option). We can do that in this PR if we want or do it in a separate PR.

However, the latest version of prettier now fails with a new syntax error which I think we would need to add "type": "module" to package.json to support - and that feels like a bigger undertaking. Our other option is to add this file to the .eslintignore file but that feels risky since we may miss syntax errors in there?

packages/react-router-dev/vite/static/refresh-utils.cjs
[error] packages/react-router-dev/vite/static/refresh-utils.cjs: SyntaxError: import.meta may appear only with 'sourceType: "module"' (160:1)
[error]   158 | window.__reactRouterRouteModuleUpdates = new Map();
[error]   159 |
[error] > 160 | import.meta.hot.on("react-router:hmr", async ({ route }) => {
[error]       | ^
[error]   161 |   window.__reactRouterClearCriticalCss();
[error]   162 |
[error]   163 |   if (route) {

Copy link

changeset-bot bot commented Jul 1, 2025

⚠️ No Changeset found

Latest commit: 15b3329

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant