Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to upgrade prettier to support
import ... with
syntax - we had to ignore an RSC integration file in 78b374b because it was breaking the format workflow.Upgrading was simple, and it causes bunch of changes which seem harmless. I did have to set
trailingComma:es5
to get the minimal set of changes (~100 files instead of 400-500 with the new defaultall
option). We can do that in this PR if we want or do it in a separate PR.However, the latest version of prettier now fails with a new syntax error which I think we would need to add
"type": "module"
topackage.json
to support - and that feels like a bigger undertaking. Our other option is to add this file to the.eslintignore
file but that feels risky since we may miss syntax errors in there?