-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
fix(dev): fix incorrect usage of defaultServerConditions
as externalConditions
#13871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dev): fix incorrect usage of defaultServerConditions
as externalConditions
#13871
Conversation
🦋 Changeset detectedLatest commit: d005142 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @Andarist, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
fb5187e
to
af2dd39
Compare
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
…itions being misapplied to `externalConditions`
af2dd39
to
2feb39a
Compare
externalConditions
defaultServerConditions
as externalConditions
defaultServerConditions
as externalConditions
defaultServerConditions
as externalConditions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've pushed some minor refactors, but this looks good to me.
…alConditions` (remix-run#13871) Co-authored-by: Mark Dalgleish <[email protected]>
Atm,
module
condition is being misapplied toexternalConditions
and that breaks packages like Emotion (see emotion-js/emotion#3333 )