Skip to content

fix(dev): fix incorrect usage of defaultServerConditions as externalConditions #13871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Jun 24, 2025

Atm, module condition is being misapplied to externalConditions and that breaks packages like Emotion (see emotion-js/emotion#3333 )

Copy link

changeset-bot bot commented Jun 24, 2025

🦋 Changeset detected

Latest commit: d005142

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 24, 2025

Hi @Andarist,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@Andarist Andarist force-pushed the fix/misapplied-server-conditions branch 2 times, most recently from fb5187e to af2dd39 Compare June 24, 2025 09:48
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 24, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

…itions being misapplied to `externalConditions`
@markdalgleish markdalgleish changed the title fix(moduleResolution): fixed an issue with Vite's default server conditions being misapplied to externalConditions fix(cloudflareDevProxy): fix incorrect usage of defaultServerConditions as externalConditions Jul 7, 2025
@markdalgleish markdalgleish changed the title fix(cloudflareDevProxy): fix incorrect usage of defaultServerConditions as externalConditions fix(dev): fix incorrect usage of defaultServerConditions as externalConditions Jul 7, 2025
@markdalgleish markdalgleish changed the base branch from main to dev July 7, 2025 01:21
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've pushed some minor refactors, but this looks good to me.

@markdalgleish markdalgleish merged commit 21fc6e5 into remix-run:dev Jul 7, 2025
8 checks passed
vezaynk pushed a commit to vezaynk/react-router that referenced this pull request Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants