Skip to content

Conversation

@nesty92
Copy link
Contributor

@nesty92 nesty92 commented Dec 26, 2025

No description provided.

@jit-ci
Copy link

jit-ci bot commented Dec 26, 2025

Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset.

In case there are security findings, they will be communicated to you as a comment inside the PR.

Hope you’ll enjoy using Jit.

Questions? Comments? Want to learn more? Get in touch with us.

@nesty92
Copy link
Contributor Author

nesty92 commented Dec 26, 2025

@rueian, would love to get your thoughts on this PR.

Quick question: should we also be updating the nodes when the redirect is active? Not 100% sure on that part.

Signed-off-by: Ernesto Alejandro Santana Hidalgo <[email protected]>
@rueian
Copy link
Collaborator

rueian commented Dec 27, 2025

Hi @nesty92, thanks for the PR. Would you mind splitting the helpers to another PR? And the index 0 of the node slice may not be the primary if the user uses ReplicaSelector instead of ReadNodeSelector. I am also wondering if the helpers can be optimized with bit operations to avoid the second round of zone string comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants