fix: Fixed potential deadlock from unexpected __del__ call#3654
Merged
vladvildanov merged 1 commit intomasterfrom May 26, 2025
Merged
fix: Fixed potential deadlock from unexpected __del__ call#3654vladvildanov merged 1 commit intomasterfrom
vladvildanov merged 1 commit intomasterfrom
Conversation
petyaslavova
pushed a commit
that referenced
this pull request
Jun 2, 2025
ManelCoutinhoSensei
pushed a commit
to ManelCoutinhoSensei/redis-py
that referenced
this pull request
Jun 30, 2025
ManelCoutinhoSensei
pushed a commit
to ManelCoutinhoSensei/redis-py
that referenced
this pull request
Jul 1, 2025
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Fixes potential deadlock when GC takes action and
__del__invoked in the middle ofget_connection()orrelease()methods.ClusterPipelineobject releases connection on__del__method which leads to a deadlock.This PR introduces only non-breaking changing fixes, the follow up PR with backward incompatible fixes will be released as a part of next major release
Closes #3289