Skip to content

Fix flaky timeout assertion in maintenance notification test #3143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2025
Merged

Fix flaky timeout assertion in maintenance notification test #3143

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2c526d
Add debug info to assertion messages for root cause analysis
kiryazovi-redis Dec 3, 2025
0173fa7
Fix flaky timeout assertion in maintenance notification test
kiryazovi-redis Dec 3, 2025
e9296a2
Apply same tolerance fix to NORMAL_COMMAND_TIMEOUT assertions
kiryazovi-redis Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions packages/client/lib/tests/test-scenario/timeout-during-notifications.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,17 +125,17 @@ describe("Timeout Handling During Notifications", () => {
notifications.forEach((notification) => {
assert.ok(
result[notification]?.error instanceof Error,
`${notification} notification error should be instanceof Error`
`${notification} notification error should be instanceof Error. Got: ${JSON.stringify(result[notification])}`
);
assert.ok(
result[notification]?.duration >= RELAXED_COMMAND_TIMEOUT &&
result[notification]?.duration >= RELAXED_COMMAND_TIMEOUT * 0.8 &&
result[notification]?.duration < RELAXED_COMMAND_TIMEOUT * 1.2,
`${notification} notification should timeout within relaxed timeout`
`${notification} notification should timeout within relaxed timeout. Duration: ${result[notification]?.duration}, Expected: [${RELAXED_COMMAND_TIMEOUT * 0.8}, ${RELAXED_COMMAND_TIMEOUT * 1.2})`
);
assert.strictEqual(
result[notification]?.error?.constructor?.name,
"CommandTimeoutDuringMaintenanceError",
`${notification} notification error should be CommandTimeoutDuringMaintenanceError`
`${notification} notification error should be CommandTimeoutDuringMaintenanceError. Got: ${result[notification]?.error?.constructor?.name}`
);
});
});
Expand Down Expand Up @@ -164,9 +164,9 @@ describe("Timeout Handling During Notifications", () => {
"Command Timeout error should be instanceof Error"
);
assert.ok(
durationMigrate >= NORMAL_COMMAND_TIMEOUT &&
durationMigrate >= NORMAL_COMMAND_TIMEOUT * 0.8 &&
durationMigrate < NORMAL_COMMAND_TIMEOUT * 1.2,
`Normal command should timeout within normal timeout ms`
`Normal command should timeout within normal timeout ms. Duration: ${durationMigrate}, Expected: [${NORMAL_COMMAND_TIMEOUT * 0.8}, ${NORMAL_COMMAND_TIMEOUT * 1.2})`
);
assert.strictEqual(
errorMigrate?.constructor?.name,
Expand Down Expand Up @@ -199,9 +199,9 @@ describe("Timeout Handling During Notifications", () => {
"Command Timeout error should be instanceof Error"
);
assert.ok(
durationBind >= NORMAL_COMMAND_TIMEOUT &&
durationBind >= NORMAL_COMMAND_TIMEOUT * 0.8 &&
durationBind < NORMAL_COMMAND_TIMEOUT * 1.2,
`Normal command should timeout within normal timeout ms`
`Normal command should timeout within normal timeout ms. Duration: ${durationBind}, Expected: [${NORMAL_COMMAND_TIMEOUT * 0.8}, ${NORMAL_COMMAND_TIMEOUT * 1.2})`
);
assert.strictEqual(
errorBind?.constructor?.name,
Expand Down
Loading