fix: negative TTL docstring, timedelta precision, and zero TTL warning#29
Open
emiliano-go wants to merge 1 commit into
Open
fix: negative TTL docstring, timedelta precision, and zero TTL warning#29emiliano-go wants to merge 1 commit into
emiliano-go wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bug: Negative TTL docstring promises ValueError that never fires
CacheBackend.set()stated "Raises ValueError: If ttl is negative" but thecode silently treated negative values as "no expiry" (identical to ttl=0).
Fix: Updated the docstring: "None or a value of 0 or below means the key
will not be automatically expired."
Bug: Timedelta TTL sub-second precision loss
CacheBackend.set()convertedtimedeltaTTLs viaint(ttl.total_seconds()), discarding sub-second values.timedelta(milliseconds=500)rounded down to 0 (no expiry).Fix: When a timedelta is provided, compute milliseconds via
int(ttl / timedelta(milliseconds=1))and passpx=toredis.set().Bug: Warning for default TTL=0 (unbounded growth)
Storing entries without an expiry (TTL=0, the default) silently persists them
forever with no indication to the caller.
Fix: Added
logger.warning(...)in both_store_cache_entry()andCacheBackend.set()when no TTL is set.