fix: telemetry recording on corrupt entries and exception log level#28
Open
emiliano-go wants to merge 1 commit into
Open
fix: telemetry recording on corrupt entries and exception log level#28emiliano-go wants to merge 1 commit into
emiliano-go wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bug: Corrupt cache entry records double telemetry (hit + miss)
record_cache_request(result="hit")and the spancache.hitattribute wereemitted before deserializing the cached response. When the entry had
corrupt JSON, the exception was caught, execution fell through to the MISS
path, and a second metric was recorded.
Fix: Deserialize first, then emit telemetry only on success. If
deserialization fails only a single "miss" metric is recorded.
Bug: Swallowed telemetry exceptions logged at DEBUG level
OpenTelemetry metric helpers (
record_cache_request,record_cache_eviction,record_cache_write,record_cache_latency) swallowed all exceptions atlogger.debug(...), making OTel errors invisible in production withoutdebug logging enabled.
Fix: Changed all four handlers to
logger.warning(...).