[RI-7194] Add "Create vector search" wizard #4718
Conversation
Code Coverage - Frontend unit tests
Test suite run success4810 tests passing in 633 suites. Report generated by 🧪jest coverage report action from 299bcf2 |
| @@ -49,6 +50,8 @@ export const Pages = { | |||
| sentinelDatabases: `${sentinel}/databases`, | |||
| sentinelDatabasesResult: `${sentinel}/databases-result`, | |||
| browser: (instanceId: string) => `/${instanceId}/${PageNames.browser}`, | |||
| vectorSearch: (instanceId: string) => | |||
There was a problem hiding this comment.
Why not just search?
There was a problem hiding this comment.
because that's the name of the epic and the target branch
I thought that was the name of the feature
|
Change the target branch to |
KrumTy
changed the base branch from
fe/feature/RI-7039-replace-eui
to
feature/RI-6855/vector-search
KrumTy
requested review from
dantovska,
ArtemHoruzhenko,
pd-redis and
KIvanow
as code owners
| }: VectorSearchCreateIndexProps) => { | ||
| const { instanceId } = useParams<{ instanceId: string }>() | ||
| const [step, setStep] = useState(initialStep) | ||
| const [createSearchIndexParameters, setCreateSearchIndexParameters] = |
There was a problem hiding this comment.
Tip: It's ok for now, since it's the first PR in a series, so I'll leave a note only to think about it.
I like the idea you went for a state variable to control this (instead of Redux), but we'll need to prop drill it to every component, in order to access some useful information. Instead of deep prop drilling, we may use React Context, and let it be a "central state storage" for the family of components related to the Vector Search setup.
But we may change this in the next PRs, once we have the other components in place and more vision on the data model itself.
There was a problem hiding this comment.
yes, context will be the way to go if deep sharing of state is needed
this is just a skeleton/wrapper component w/o actual functionality after all
…nto fe/RI-7194/create-vector-search-wizard
| @@ -93,6 +93,7 @@ module.exports = { | |||
| 'sonarjs/no-duplicate-string': 'off', | |||
| 'sonarjs/cognitive-complexity': [1, 20], | |||
| 'sonarjs/no-identical-functions': [0, 5], | |||
| 'sonarjs/no-nested-template-literals': 'off', | |||
There was a problem hiding this comment.
turned off so we can we can add theme related css inside styled components without an extra wrapper function
No description provided.