Reintroduce the stickybox on wide screens #604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
humitos
approved these changes
Jun 23, 2025
agjohnson
approved these changes
Jun 24, 2025
| @@ -198,11 +198,22 @@ export class EthicalAdsAddon extends AddonBase { | |||
| if (elementToAppend) { | |||
| elementToAppend.append(placement); | |||
| } | |||
| } else if (window.innerWidth > 1300 && Math.random() > 0.5) { | |||
There was a problem hiding this comment.
This could be another place to eventually use media query events, so that we can re-evaluate this logic if the view port size changes. This will just execute once on page load.
Noting for later, I don't think we are using this type of logic anywhere else yet.
ericholscher
approved these changes
Jun 24, 2025
| @@ -198,11 +198,22 @@ export class EthicalAdsAddon extends AddonBase { | |||
| if (elementToAppend) { | |||
| elementToAppend.append(placement); | |||
| } | |||
| } else if (window.innerWidth > 1300 && Math.random() > 0.5) { | |||
There was a problem hiding this comment.
I'd like to avoid the randomness here. I think a better approach is using the same logic for each user, so it doesn't change randomly on refresh.
|
Will merge this for release today. |
ericholscher
deleted the
davidfischer/reintroduce-stickybox-on-widescreens
branch
|
Did a simple version here: #607 |
ericholscher
added a commit
that referenced
this pull request
Jun 25, 2025
This reverts commit bc62388.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternates between using the stickybox placement and the footer placement on unknown themes. It also adds an ID to the stickybox placement so we can see performance of it.
As written, this introduces a random element which may not be desirable. We could instead introduce the stickybox only on very wide screens (say >=1600px) or we could base it on the title of the project or something like that to make it deterministic. I'm open to suggestions.
The footer placement is performing very well at ~4x the CTR with ~50% the view rate vs. previously.
Ref: #562