Address code review feedback for PR #4240 #4241
Merged
+18
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
- Fix type mismatch in EvalBindingHooks call (pass object, IViewFor type args) - Add synchronization to hostChanges to prevent race conditions - Convert static SetCallCount to instance-level in BindToNestedPropertyTests - Update ViewModel property to use RaiseAndSetIfChanged pattern - Fix test expectations after converting to instance counters - Remove redundant using directives from PropertyBindingTest.cs - Fix test expectation for deduplicated setter calls (9 -> 3) - Remove readonly modifier from _nested field to allow RaiseAndSetIfChanged Co-authored-by: ChrisPulman <[email protected]>
Use explicit backing field instead of field keyword with separate initializer to improve code clarity. Co-authored-by: ChrisPulman <[email protected]>
Copilot
AI
changed the title
[WIP] Fix nested property binding to avoid redundant setter calls
Address code review feedback for PR #4240
Dec 21, 2025
Copilot stopped work on behalf of
ChrisPulman due to an error
December 21, 2025 17:14
Member
|
@copilot Continue to resolve until completed |
Contributor
Author
All code review feedback has been addressed and verified. Changes include:
All 294 tests passing across .NET 8.0, 9.0, and 10.0. Build successful with 0 errors. |
ChrisPulman
approved these changes
Dec 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses code review comments from the nested property binding fix, focusing on type safety, thread safety, and test maintainability.
Changes
Type Safety
EvalBindingHookscall to provide both required type arguments<object, IViewFor>(was missing second type parameter causing compilation error)Thread Safety
.Synchronize()tohostChangesobservable to prevent race conditions betweenhostDisposableandchangeDisposablesubscriptions accessing shared state variablesTest Infrastructure
SetCallCountfrom static to instance-level properties in test classes to prevent test isolation issues during parallel executionCode Cleanup
readonlymodifier from_nestedfield to allowRaiseAndSetIfChangedAll tests passing (294/294) across .NET 8.0, 9.0, and 10.0.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.