feat(iOS): serve third-party deps from the prebuilt ReactNativeDependencies pod via dependency-only facades by chrfalch · Pull Request #57440 · react/react-native

chrfalch · 2026-07-06T09:20:39Z

Summary

Step 1 of making the prebuilt ReactNativeDependencies pod the single header authority for the third-party C/C++ deps (RCT-Folly, glog, boost, DoubleConversion, fmt, fast_float, SocketRocket) in prebuilt-deps mode.

Today the deps binary replaces the source pods' code, but the pod still s.dependency's the real source pods and borrows their headers via $(PODS_ROOT)/<pod> search paths. That split header authority is the dual-copy bug class behind the 2026-07-03 SocketRocket regression (duplicate @interface under use_frameworks! — SocketRocket's ObjC headers have no include guards).

Three commits:

fix(cocoapods): harden prebuilt-deps header search paths and artifact handling — rndependencies.rb's ||= [] << path only added the deps header search path when HEADER_SEARCH_PATHS was unset (silently dropped otherwise); normalize and always append, and point at the pod-local flattened Headers/. ReactNativeDependencies.podspec prepare_command now fails closed (exit 1) instead of silently producing a no-link pod. reactNativeDependencies.js no longer deletes + re-downloads a locally staged artifact that lacks a version marker.
feat(cocoapods): dependency-only facades for third-party pods in prebuilt-deps mode — in prebuilt-deps mode the real source pods are not declared, so a community podspec's hardcoded s.dependency "RCT-Folly" would resolve from trunk and compile from source next to the prebuilt binary. RNDepsFacades generates dependency-only local facade podspecs (no sources, no headers, a single dependency on ReactNativeDependencies); versions/subspecs are derived from the real podspecs in third-party-podspecs/ (SocketRocket synthesized fail-closed from socket_rocket_config). Full contract documented in scripts/cocoapods/__docs__/prebuilt-deps.md.
feat(ios-prebuild): SocketRocket privacy manifest + Xcode 26 header layout — embed an RN-authored, accurate-empty PrivacyInfo.xcprivacy for SocketRocket (upstream ships none), and stage flat public headers into include/ so Xcode 26's SwiftPM accepts the header layout.

Stacked on #57305 (base: chrfalch/prebuilt-resources); the SwiftPM preview (#57332) rebases on top of this. Follow-up (separate PR): headers-only ReactNativeDependenciesHeaders.xcframework sidecar so SPM auto-serves the deps namespaces and ReactNativeHeaders goes pure-RN.

Changelog:

[IOS][CHANGED] - Prebuilt-deps mode: serve third-party headers from the ReactNativeDependencies pod itself and resolve community s.dependency on RCT-Folly/glog/boost/etc. via dependency-only facade pods

Test Plan

E2E matrix (2026-07-06, locally built deps artifact via prepare-ios-prebuilds.js):

rn-tester, prebuilt core + prebuilt deps, static linkage — builds
rn-tester, prebuilt core + prebuilt deps, USE_FRAMEWORKS=dynamic — builds (the SocketRocket-regression config)
helloworld (private), prebuilt core + prebuilt deps, static — builds
source-mode control: no facades generated, Podfile.lock identical to baseline

🤖 Generated with Claude Code

github-actions · 2026-07-06T09:21:36Z

Caution

Invalid Base Branch

The base branch for this PR is chrfalch/prebuilt-resources, which is not main or a -stable branch.
Are you sure you want to target this branch?

… handling - rndependencies.rb: the previous "||= [] << path" only added the deps header search path when HEADER_SEARCH_PATHS was unset — with an existing value the path was silently dropped. Normalize string values and always append. Also point the search path at the pod-local flattened Headers/ (single header home) instead of the artifact root. - ReactNativeDependencies.podspec: prepare_command exited 0 when XCFRAMEWORK_PATH/HEADERS_PATH resolved empty, producing a silent no-link pod; fail closed with exit 1. - reactNativeDependencies.js: an artifact without a version marker logged "we are going to use it anyway" but then fell through to rmSync + re-download, destroying locally staged deps builds; honor the message and use it as-is. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…uilt-deps mode In prebuilt-deps mode the real source pods (RCT-Folly, glog, boost, DoubleConversion, fmt, fast_float, SocketRocket) are not declared in the Podfile, so a community podspec's hardcoded 's.dependency "RCT-Folly"' would resolve from the CocoaPods trunk and compile from source next to the prebuilt binary — the dual-copy bug class behind the 2026-07-03 SocketRocket regression. RNDepsFacades generates dependency-only local facade podspecs (build/rndeps-facades/<Name>/): no sources, no headers, a single dependency on ReactNativeDependencies. Versions and subspecs are derived from the real podspecs in third-party-podspecs/ (RCT-Folly keeps /Default + /Fabric with default_subspecs = ["Default"]; SocketRocket is synthesized from socket_rocket_config, fail-closed if absent). Declared as :path pods so Podfile-local resolution beats trunk and nothing is fetched. ReactNativeDependencies remains the single header authority. Docs: scripts/cocoapods/__docs__/prebuilt-deps.md describes the full prebuilt-deps header/facade contract and the mode-by-mode supplier table. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

…ayout - Embed an RN-authored, accurate-empty PrivacyInfo.xcprivacy for SocketRocket in the deps prebuild (upstream ships no privacy manifest; the deps artifact historically carried resource bundles only for boost/folly/glog). SocketRocket uses no Required Reason APIs. - Xcode 26's SwiftPM rejects a public-headers directory where the umbrella header has sibling directories ("target 'SocketRocket' has invalid header layout"): stage the flat public headers into include/ via prepareScript and point publicHeaderFiles there. Xcode 16 accepts both layouts; the artifact's Headers/SocketRocket namespace is unaffected. - Rename the dependency 'socket-rocket' -> 'SocketRocket' so the bundle and header-namespace naming line up (ReactNativeDependencies_SocketRocket.bundle). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Pure formatting — no content change. Fixes the format-check lint lane. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

cipolleschi · 2026-07-08T08:13:33Z

+# Dependency-only facade podspecs for the third-party deps in prebuilt-deps
+# mode (deps-side analogue of RNCoreFacades). Design + rationale:
+# scripts/cocoapods/__docs__/prebuilt-deps.md
+module RNDepsFacades


Major (test coverage): This entire new module ships without tests, and several branchy behaviors are unit-testable without a full pod install: derive_subspecs filtering, the two synthesized_version fail-closed raise paths, derived_spec version/subspec derivation, and load_real_spec's missing-vs-unparseable errors. These error contracts are load-bearing (a silently-empty facade would hide drift) and deserve a few RSpec/minitest cases.

cipolleschi · 2026-07-08T08:13:44Z

+        subspecs = derive_subspecs(real)
+        unless subspecs.empty?
+            spec["subspecs"] = subspecs.map do |ss|
+                { "name" => ss, "dependencies" => { DEPS_POD => [] } }


Minor: Every derived subspec is emitted depending only on ReactNativeDependencies, so the facade RCT-Folly/Fabric loses the real subspec's dependency on RCT-Folly/Default. Low impact in practice (all six deps are declared explicitly in react_native_pods.rb), but the facade graph isn't truly 'graph-equivalent to the source pod' as the header comment claims — either preserve intra-pod subspec deps or soften the comment.

cipolleschi · 2026-07-08T08:13:45Z

+      // Honor the message above: an artifact without a version marker is a
+      // locally-staged one (e.g. a freshly composed deps build) — falling
+      // through here rmSync'd it and re-downloaded. Use it as-is.
+      return true;


Minor: This early return true runs before the version.txt write below, so a locally-staged artifact never gets a version marker. Every later run re-hits this branch and returns true, meaning a subsequent version change won't invalidate the staged artifact until it's manually removed. Matches the stated intent, but worth a one-line comment since downstream code assuming version.txt exists would be surprised.

cipolleschi · 2026-07-08T08:13:46Z

+    def self.synthesized_version(name)
+        case name
+        when "SocketRocket"
+            unless defined?(Helpers::Constants) && Helpers::Constants.respond_to?(:socket_rocket_config)


Minor: This references Helpers::Constants but the file only requires json and fileutils; it works solely because react_native_pods.rb loads helpers.rb first. The defined? guard keeps it fail-closed, but a require_relative './helpers.rb' would make the module self-contained against require reordering.

cipolleschi · 2026-07-08T08:13:47Z

+In prebuilt-deps mode the `ReactNativeDependencies` POD (CocoaPods) is the
+single authority for the third-party deps: compiled code lives in its
+xcframework binary, and the artifact's own
+`Headers/{folly,glog,boost,fmt,double-conversion,fast_float, SocketRocket}` are


Nit: Stray space before SocketRocket in the Headers/{...} list.

cipolleschi · 2026-07-08T08:13:48Z

+        end
+        # Artifact headers are flattened into the pod-local Headers/ by the podspec
+        # prepare_command (see __docs__/prebuilt-deps.md).
+        header_search_paths << "$(PODS_ROOT)/ReactNativeDependencies/Headers"


Nit: This appends the search path unconditionally; if add_rn_third_party_dependencies ran twice on the same spec the entry would duplicate. Low risk (one call per spec) and now symmetric with the from-source branch — just noting.

cipolleschi · 2026-07-08T08:13:49Z

    if [ -z "$XCFRAMEWORK_PATH" ]; then
      echo "ERROR: XCFRAMEWORK_PATH is empty."
-      exit 0
+      exit 1


Good catch — this is a real bug fix. The old prepare_command printed 'ERROR' then exited 0, silently producing a broken install with no flattened headers; failing loudly is correct.

cipolleschi · 2026-07-08T08:13:49Z

        s.dependency "ReactNativeDependencies"
-        current_pod_target_xcconfig["HEADER_SEARCH_PATHS"] ||= [] << "$(PODS_ROOT)/ReactNativeDependencies"
+
+        header_search_paths = current_pod_target_xcconfig["HEADER_SEARCH_PATHS"] || []


Nice — this mirrors the from-source branch's String-vs-Array handling and fixes the prior ||= [] << ... idiom that never appended when the key already existed.

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 6, 2026

facebook-github-tools Bot added p: Expo Partner: Expo Partner labels Jul 6, 2026

chrfalch mentioned this pull request Jul 6, 2026

feat(iOS): ReactNativeDependenciesHeaders sidecar + pure-RN ReactNativeHeaders, published to Maven #57442

Open

chrfalch requested a review from cipolleschi July 6, 2026 12:22

chrfalch and others added 4 commits July 6, 2026 18:36

chore: prettier formatting for prebuilt-deps doc and configuration.js

017ca51

Pure formatting — no content change. Fixes the format-check lint lane. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

chrfalch force-pushed the chrfalch/prebuilt-resources branch from 8158f41 to 562985d Compare July 6, 2026 16:37

chrfalch force-pushed the chrfalch/prebuilt-deps-facades branch from 069c350 to 017ca51 Compare July 6, 2026 16:37

chrfalch mentioned this pull request Jul 6, 2026

feat(iOS) swiftpm support in iOS #57332

Open

cipolleschi reviewed Jul 8, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(iOS): serve third-party deps from the prebuilt ReactNativeDependencies pod via dependency-only facades#57440

feat(iOS): serve third-party deps from the prebuilt ReactNativeDependencies pod via dependency-only facades#57440
chrfalch wants to merge 4 commits into
chrfalch/prebuilt-resourcesfrom
chrfalch/prebuilt-deps-facades

chrfalch commented Jul 6, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 6, 2026 •

edited

Loading

Uh oh!

cipolleschi Jul 8, 2026

Uh oh!

cipolleschi Jul 8, 2026

Uh oh!

cipolleschi Jul 8, 2026

Uh oh!

cipolleschi Jul 8, 2026

Uh oh!

cipolleschi Jul 8, 2026

Uh oh!

cipolleschi Jul 8, 2026

Uh oh!

cipolleschi Jul 8, 2026

Uh oh!

cipolleschi Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

chrfalch commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changelog:

Test Plan

Uh oh!

github-actions Bot commented Jul 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chrfalch commented Jul 6, 2026 •

edited

Loading

github-actions Bot commented Jul 6, 2026 •

edited

Loading