Skip to content

fix(ios): perf issues w/ image masks #57399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hannojg wants to merge 3 commits into
base: main
Choose a base branch
from
+31 −14
Open

fix(ios): perf issues w/ image masks #57399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
508038a
perf(ios): only apply layer mask to UIImageView when none circular bo…
hannojg Jul 1, 2026
8acdcaf
the wrapping RCTViewComponentView does the clipping, this is unnecess…
hannojg Jul 1, 2026
0238d11
example: add example of none circular uniform border radius
hannojg Jul 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/react-native/React/Fabric/Mounting/ComponentViews/Image/RCTImageComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ - (instancetype)initWithFrame:(CGRect)frame
_props = defaultProps;

_imageView = [RCTUIImageViewAnimated new];
_imageView.clipsToBounds = YES;

@hannojg hannojg Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really needed as the outer RCTViewComponentView will properly do the clipping / apply a mask, so this is actually redundant here

_imageView.contentMode = RCTContentModeFromImageResizeMode(defaultProps->resizeMode);
_imageView.layer.minificationFilter = kCAFilterTrilinear;
_imageView.layer.magnificationFilter = kCAFilterTrilinear;
Expand Down
33 changes: 20 additions & 13 deletions packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -995,6 +995,7 @@ - (void)invalidateLayer
}

const auto borderMetrics = _props->resolveBorderMetrics(_layoutMetrics);
BOOL const borderRadiiCircular = areBorderRadiiCircular(borderMetrics.borderRadii);

// Stage 1. Shadow Path
BOOL const layerHasShadow = layer.shadowOpacity > 0 && CGColorGetAlpha(layer.shadowColor) > 0;
Expand Down Expand Up @@ -1044,7 +1045,7 @@ - (void)invalidateLayer
const bool useCoreAnimationBorderRendering =
borderMetrics.borderColors.isUniform() && borderMetrics.borderWidths.isUniform() &&
borderMetrics.borderStyles.isUniform() && borderMetrics.borderStyles.left == BorderStyle::Solid &&
areBorderRadiiCircular(borderMetrics.borderRadii) &&
borderRadiiCircular &&
(
// iOS draws borders in front of the content whereas CSS draws them behind
// the content. For this reason, only use iOS border drawing when clipping
Expand Down Expand Up @@ -1126,7 +1127,7 @@ - (void)invalidateLayer
_outlineLayer.frame = CGRectInset(
layer.bounds, -_props->outlineOffset - _props->outlineWidth, -_props->outlineOffset - _props->outlineWidth);

if (areBorderRadiiCircular(borderMetrics.borderRadii) && borderMetrics.borderRadii.topLeft.horizontal == 0) {
if (borderRadiiCircular && borderMetrics.borderRadii.topLeft.horizontal == 0) {
UIColor *outlineColor = RCTUIColorFromSharedColor(_props->outlineColor);
_outlineLayer.borderWidth = _props->outlineWidth;
_outlineLayer.borderColor = outlineColor.CGColor;
Expand Down Expand Up @@ -1302,7 +1303,7 @@ - (void)invalidateLayer
if (self.currentContainerView.clipsToBounds) {
BOOL clipToPaddingBox = ReactNativeFeatureFlags::enableIOSViewClipToPaddingBox();
if (!clipToPaddingBox) {
if (areBorderRadiiCircular(borderMetrics.borderRadii)) {
if (borderRadiiCircular) {
self.currentContainerView.layer.cornerRadius = borderMetrics.borderRadii.topLeft.horizontal;
} else {
CALayer *maskLayer =
Expand All @@ -1312,20 +1313,26 @@ - (void)invalidateLayer
self.currentContainerView.layer.mask = maskLayer;
}

for (UIView *subview in self.currentContainerView.subviews) {
if ([subview isKindOfClass:[UIImageView class]]) {
RCTCornerInsets cornerInsets = RCTGetCornerInsets(
RCTCornerRadiiFromBorderRadii(borderMetrics.borderRadii),
RCTUIEdgeInsetsFromEdgeInsets(borderMetrics.borderWidths));

// If the subview is an image view, we have to apply the mask directly to the image view's layer,
// otherwise the image might overflow with the border radius.
subview.layer.mask = [self createMaskLayer:subview.bounds cornerInsets:cornerInsets];
if (!borderRadiiCircular &&
(borderMetrics.borderColors.left || borderMetrics.borderColors.right || borderMetrics.borderColors.top ||
borderMetrics.borderColors.bottom)) {
for (UIView *subview in self.currentContainerView.subviews) {
if ([subview isKindOfClass:[UIImageView class]]) {
RCTCornerInsets cornerInsets = RCTGetCornerInsets(
RCTCornerRadiiFromBorderRadii(borderMetrics.borderRadii),
RCTUIEdgeInsetsFromEdgeInsets(borderMetrics.borderWidths));

// If the subview is an image view, we have to apply the mask directly to the image view's layer,
// otherwise the image might overflow with the border radius.
// Applying a mask is rendering wise expensive so we only apply it when needed, which is only
// for none uniform border radii (that are actually visible by color).
subview.layer.mask = [self createMaskLayer:subview.bounds cornerInsets:cornerInsets];
}
}
}
} else if (
!borderMetrics.borderWidths.isUniform() || borderMetrics.borderWidths.left != 0 ||
!areBorderRadiiCircular(borderMetrics.borderRadii)) {
!borderRadiiCircular) {
CALayer *maskLayer = [self createMaskLayer:RCTCGRectFromRect(_layoutMetrics.getPaddingFrame())
cornerInsets:RCTGetCornerInsets(
RCTCornerRadiiFromBorderRadii(borderMetrics.borderRadii),
Expand Down
11 changes: 11 additions & 0 deletions packages/rn-tester/js/examples/Image/ImageExample.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,6 +1051,13 @@ const styles = StyleSheet.create({
flex: {
flex: 1,
},
imageWithUniformButNoneCircularBorderRadius: {
width: 200,
height: 100,
borderRadius: '50%',
borderWidth: 4,
borderColor: 'blue',
},
imageWithBorderRadius: {
borderRadius: 5,
},
Expand Down Expand Up @@ -1420,6 +1427,10 @@ exports.examples = [
render: function (): React.Node {
return (
<View style={styles.horizontal} testID="border-radius-example">
<Image
style={styles.imageWithUniformButNoneCircularBorderRadius}
source={fullImage}
/>
<Image
style={[styles.base, styles.imageWithBorderRadius]}
source={fullImage}
Expand Down
Loading