Skip to content

Conversation

@NripeshN
Copy link

@NripeshN NripeshN commented Aug 15, 2023

Why are these changes needed?

Related issue number

Closes #39136

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@NripeshN
Copy link
Author

hi @krfricke, created a new PR because I messed up my old one.

@stale
Copy link

stale bot commented Sep 17, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Sep 17, 2023
@NripeshN
Copy link
Author

hi @krfricke, please review this PR

@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Sep 29, 2023
@jjyao
Copy link
Collaborator

jjyao commented Oct 24, 2023

Hi @NripeshN,

Thanks for the contribution. As the first step, we need to support Apple silicon GPU in Ray core. Could you follow #38553 as an example to update the PR? Thanks!

@jjyao jjyao self-assigned this Oct 24, 2023
Copy link
Collaborator

@jjyao jjyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase with master

@NripeshN NripeshN requested a review from jjyao October 27, 2023 21:59
@anyscalesam
Copy link
Contributor

@jjyao this feels like a good thing to push through to enable better support for local dev/test on apple silicon. reminder to take a look. im adding this to core-sprint so we don't forget.

@NripeshN
Copy link
Author

Can you run

hey @NripeshN are you still interested in updating this and putting it through?

Hiya @dayshah Just attempted the PR, feel free to review it😁

can you fix the pre-commit, can follow the directions here https://docs.ray.io/en/latest/ray-contribute/getting-involved.html#lint-and-formatting

Sorry no idea how I missed this comment, just fixed the lint errors.

@NripeshN NripeshN requested a review from dayshah June 18, 2025 22:01
@dayshah dayshah added go add ONLY when ready to merge, run all tests and removed @external-author-action-required Alternate tag for PRs where the author doesn't have labeling permission. labels Jun 26, 2025
@jjyao
Copy link
Collaborator

jjyao commented Jul 12, 2025

I'll try to see if we can find someone from Apple to review this.

@github-actions
Copy link

github-actions bot commented Aug 2, 2025

This pull request has been automatically marked as stale because it has not had
any activity for 14 days. It will be closed in another 14 days if no further activity occurs.
Thank you for your contributions.

You can always ask for help on our discussion forum or Ray's public slack channel.

If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@github-actions github-actions bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Aug 2, 2025
@NripeshN NripeshN requested a review from a team as a code owner August 8, 2025 12:44
@github-actions github-actions bot added unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it. and removed stale The issue is stale. It will be closed within 7 days unless there are further conversation labels Aug 9, 2025
@jjyao
Copy link
Collaborator

jjyao commented Oct 1, 2025

Quick update: we currently expect that an Apple employee will review this in the coming weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests P2 Important issue, but not time-critical unstale A PR that has been marked unstale. It will not get marked stale again if this label is on it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Core] Identify Mac M1/M2 GPUs as valid GPUs

6 participants