-
Notifications
You must be signed in to change notification settings - Fork 7.1k
Add Apple silicon GPU(mps) support to ray #38464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: NripeshN <[email protected]>
|
hi @krfricke, created a new PR because I messed up my old one. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
|
hi @krfricke, please review this PR |
Signed-off-by: Nripesh Niketan <[email protected]>
jjyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase with master
Signed-off-by: Nripesh Niketan <[email protected]>
Signed-off-by: Nripesh Niketan <[email protected]>
|
@jjyao this feels like a good thing to push through to enable better support for local dev/test on apple silicon. reminder to take a look. im adding this to core-sprint so we don't forget. |
Sorry no idea how I missed this comment, just fixed the lint errors. |
|
I'll try to see if we can find someone from Apple to review this. |
|
This pull request has been automatically marked as stale because it has not had You can always ask for help on our discussion forum or Ray's public slack channel. If you'd like to keep this open, just leave any comment, and the stale label will be removed. |
|
Quick update: we currently expect that an Apple employee will review this in the coming weeks. |
Why are these changes needed?
Related issue number
Closes #39136
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.