Skip to content

Experimental parquet APIs to take ownership of roaring bitmap buffers #21044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mhaseeb123 wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Experimental parquet APIs to take ownership of roaring bitmap buffers #21044

mhaseeb123 wants to merge 9 commits into from
+138 −177

Conversation

@mhaseeb123
Copy link
Member

@mhaseeb123 mhaseeb123 commented Jan 14, 2026 •
edited
Loading

Description

This PR updates the experimental Parquet APIs to take ownership of roaring bitmap buffers

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mhaseeb123 mhaseeb123 requested a review from a team as a code owner January 14, 2026 20:22
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jan 14, 2026
@mhaseeb123 mhaseeb123 moved this to Burndown in libcudf Jan 14, 2026
@mhaseeb123 mhaseeb123 added bug Something isn't working 4 - Needs Review Waiting for reviewer to review or respond Spark Functionality that helps Spark RAPIDS cuIO cuIO issue non-breaking Non-breaking change labels Jan 14, 2026
@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 15, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mhaseeb123 mhaseeb123 changed the title Minor bug fix to handle empty roaring bitmap Experimental parquet APIs to take ownership of roaring bitmap buffers Jan 16, 2026
mhaseeb123
mhaseeb123 commented Jan 16, 2026
View reviewed changes
cpp/include/cudf/io/experimental/deletion_vectors.hpp
* @param stream CUDA stream used for device memory operations and kernel launches
* @param mr Device memory resource to use for device memory allocation
*/
chunked_parquet_reader(
Copy link
Member Author

@mhaseeb123 mhaseeb123 Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed these confusion causing constructors.

@mhaseeb123 mhaseeb123 added feature request New feature or request and removed bug Something isn't working labels Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@kingcrimsontianyu kingcrimsontianyu Awaiting requested review from kingcrimsontianyu kingcrimsontianyu is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

At least 1 approving review is required to merge this pull request.

Assignees

@mhaseeb123 mhaseeb123

Labels

4 - Needs Review Waiting for reviewer to review or respond cuIO cuIO issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change Spark Functionality that helps Spark RAPIDS

Projects

libcudf
Status: Burndown

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mhaseeb123