Refactor key remapping #21041
Draft
Refactor key remapping #21041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename key_remapping class to join_factorizer for clarity - Update all file names from key_remapping to join_factorizer - Rename enum compute_metrics to factorizer_metrics (YES/NO → ENABLE/DISABLE) - Update sentinel constants: KEY_REMAP_* to FACTORIZE_* - Rename methods: remap_*_keys() to factorize_*_keys() - Update Java classes: KeyRemapping to JoinFactorizer - Update all CMakeLists.txt and build files - Apply clang-format
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
bot
added
libcudf
abellina
reviewed
Jan 14, 2026
| // for the join type selection heuristic, either way) | ||
| cudf::key_remapping remap( | ||
| cudf::join_factorizer remap( | ||
| build_keys, NullEquality, cudf::compute_metrics::NO, cudf::get_default_stream()); |
Contributor
There was a problem hiding this comment.
do you want to change build_keys here to right_keys as well?
| } | ||
|
|
||
| // Left with values 0-99 (all exist) and 100-104 (don't exist) | ||
| std::vector<int32_t> probe_data; |
Contributor
There was a problem hiding this comment.
should this with left_data?
| // Build with struct{INT32, STRING} | ||
| column_wrapper<int32_t> build_child1{1, 2, 3}; | ||
| strcol_wrapper build_child2{"a", "b", "c"}; | ||
| auto build_struct = cudf::test::structs_column_wrapper{{build_child1, build_child2}}; |
Contributor
There was a problem hiding this comment.
same type of comment here, not sure if the idea to make these build/probe names all consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist