Update and combine ssh key persistence with mixin #20778
+712
−978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvoisin
reviewed
Dec 16, 2025
| 'h00die <[email protected]>', # linux | ||
| 'Dean Welch <dean_welch[at]rapid7.com>' # windows | ||
| ], | ||
| 'Platform' => %w[linux win], |
Contributor
There was a problem hiding this comment.
Suggested change
| 'Platform' => %w[linux win], | |
| 'Platform' => %w[unix win], |
As this works on AIX/BSD/OSX/Solaris/… as well.
Contributor
Author
There was a problem hiding this comment.
I thought about this originally, and testing it on OSX, however since OSX has diff home directory locations so some of the assumptions in the module may not work. Also, my back log of persistence modules is long, so I wanted to KISS and just combine the two and let someone else expand if if they want to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines the Windows and Linux ssh key persistence modules, then applies the new mixin. Part of #20374
Verification
See documentation