Pod prefix #9
Open
Pod prefix #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatjindal
reviewed
Sep 25, 2021
pkg/cmd/evict_pod.go
Outdated
| } | ||
|
|
||
| if len(args) > 1 { | ||
| o.podNames = args |
Owner
There was a problem hiding this comment.
can this be merged with above if condition?
if len(args) > 0 {
o.podNames = args
}
rajatjindal
reviewed
Aug 21, 2022
|
|
||
| if len(o.args) > 0 { | ||
| o.podName = o.args[0] | ||
| if len(args) == 0 { |
Owner
There was a problem hiding this comment.
apologies for super delay in reviewing this PR. if only label is provided, the len(args) can be 0 right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mergeable after #8.
Fixes #7.
This strips out a prefix of
pod/if it exists in the request, before sending to the Kubernetes API. It overwrites the current value, but my thoughts are that there is no need for the user to care about this prefix, nor the Kubernetes API, if it exists.