refactor(desktop): Save downloads to user's Downloads folder #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the download location for desktop platforms (Windows, macOS, Linux) from a temporary, app-specific directory to the standard user "Downloads" folder. Key changes: - Introduced a `userDownloadsDir()` function in `FileLocationsProvider` to abstract the platform-specific path to the user's Downloads directory. - Implemented `userDownloadsDir()` in `DesktopFileLocationsProvider` to correctly resolve the Downloads path for Windows, macOS, and Linux (including XDG support). - Updated `DesktopDownloader` to use the new `userDownloadsDir()` for saving downloaded files. - Added a Snackbar notification on desktop to inform the user that the installer has been saved to their Downloads folder, as auto-installation is not performed. - The `saveInstalledAppToDatabase` logic is now skipped for desktop platforms, as the app is not "installed" in the same way as on Android.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the download location for desktop platforms (Windows, macOS, Linux) from a temporary, app-specific directory to the standard user "Downloads" folder.
Key changes:
userDownloadsDir()function inFileLocationsProviderto abstract the platform-specific path to the user's Downloads directory.userDownloadsDir()inDesktopFileLocationsProviderto correctly resolve the Downloads path for Windows, macOS, and Linux (including XDG support).DesktopDownloaderto use the newuserDownloadsDir()for saving downloaded files.saveInstalledAppToDatabaselogic is now skipped for desktop platforms, as the app is not "installed" in the same way as on Android.