Implement Engines Support #554
+155
−46
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| PATH | ||
| remote: . | ||
| specs: | ||
| tailwindcss-rails (4.2.3) | ||
| railties (>= 7.0.0) | ||
| tailwindcss-ruby (~> 4.0) | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| module Tailwindcss | ||
| module Engines | ||
| class << self | ||
| def bundle | ||
| FileUtils.mkdir_p(Rails.root.join("app/assets/builds/tailwind")) | ||
| Rails::Engine.subclasses.select do |engine| | ||
| engine.root.join("app/assets/tailwind/#{engine.engine_name}/application.css").exist? | ||
|
There was a problem hiding this comment. Naming this file "application.css" seems odd given it's the CSS for an engine (not an application). Why not "#{engine_name}/engine.css"? I don't feel strongly about it, just curious. There was a problem hiding this comment. Good call, it'll reduce the chances that the developer will mix app/engine files. Done and tested on local. |
||
| end.each do |engine| | ||
| file_path = Rails.root.join("app/assets/builds/tailwind/#{engine.engine_name}.css") | ||
flavorjones marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| FileUtils.rm(file_path) if File.exist?(file_path) | ||
| template = <<~TEMPLATE | ||
| /* DO NOT MODIFY THIS FILE, it was auto-generated by tailwindcss-rails */ | ||
|
|
||
| @import "#{engine.root.join("app/assets/tailwind/#{engine.engine_name}/application.css")}"; | ||
| TEMPLATE | ||
| File.open(file_path, 'w') do |file| | ||
| file.puts template | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| require "test_helper" | ||
| require "minitest/mock" | ||
|
|
||
| class Tailwindcss::EngineTest < ActiveSupport::TestCase | ||
| def setup | ||
| super | ||
| # Store original Rails state | ||
| @original_rails_root = Rails.root | ||
| @original_application = Rails.application | ||
| end | ||
|
|
||
| def teardown | ||
| super | ||
| # Restore original Rails state | ||
| Rails.application = @original_application if @original_application | ||
| end | ||
|
|
||
| test "after_initialize calls Tailwindcss::Engines.bundle" do | ||
| called = false | ||
|
|
||
| # Replace bundle method with our spy | ||
| Tailwindcss::Engines.stub(:bundle, ->{ called = true }) do | ||
| # Execute the after_initialize block | ||
| Rails.stub(:root, File) do | ||
| engine_file = File.join(File.dirname(__FILE__), "../../../lib/tailwindcss/engine.rb") | ||
| engine_code = File.read(engine_file) | ||
|
|
||
| # Verify that the after_initialize block calls Engines.bundle | ||
| assert_match(/config\.after_initialize do.*?Tailwindcss::Engines\.bundle.*?end/m, engine_code, | ||
| "Expected after_initialize block to call Tailwindcss::Engines.bundle") | ||
|
|
||
| # Call bundle to verify our spy works | ||
| Tailwindcss::Engines.bundle | ||
| assert called, "Expected Tailwindcss::Engines.bundle to be called" | ||
| end | ||
| end | ||
| end | ||
|
There was a problem hiding this comment. I don't think this test is meaningful. I would remove it and either
There was a problem hiding this comment. I looked over |
||
| end | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wrapped incorrectly, probably because the linting tool you're using is paying attention to the incorrect code block type
html. It should beruby.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect it's ToC update that did it. Corrected.