Avoid using Sprockets::Utils.module_include in SasscProcessor#798
Closed
ntkme wants to merge 1 commit intorails:mainfrom
ntkme:main
Closed
Avoid using Sprockets::Utils.module_include in SasscProcessor#798ntkme wants to merge 1 commit intorails:mainfrom ntkme:main
Sprockets::Utils.module_include in SasscProcessor#798ntkme wants to merge 1 commit intorails:mainfrom
ntkme:main
Conversation
ntkme
commented
Jan 2, 2024
Contributor
Author
|
Aborting this PR as the same feature has been merged into dartsass-sprockets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously in #759 a mutex lock was added to
Sprockets::Utils.module_includeto make it thread safe. Forsassit was the only option, becauseSass::Enginedoes not allow user to configure where functions are loaded from.However, for
SasscProcessorwe don't have to suffer from this lock, becauseSassC::Engine's API allows user to directly specify a user definedModulefor functions:https://github.com/sass/sassc-ruby/blob/4fce2b635ca5d616a8b1381c64846410bc785ea4/lib/sassc/engine.rb#L19
So instead of including
@functionsintoSassC::Script::Functions, we can do the other way around, which is to includeSassC::Script::Functionsinto@functionsand then pass@functionsinto the engine. This way we have thread safety without the mutex lock.cc @chadlwilson @rafaelfranca