refactor(select.tsx): resolved incorrect accessibility labeling with aria-selected #3518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We removed isFocused from the condition that determines the aria-selected attribute in the SelectItem component.
As-is:
aria-selected is set to true only when both isSelected and isFocused are true.
However, this can cause confusion for users—if an item is actually selected (indicated with a checkmark) and its state has changed, but isFocused is false, then aria-selected is also false.
To-be:
Regardless of focus, once a user selects an item, aria-selected is immediately set to true to reflect the updated state.