Fix type mixups of ra_index() and ra_term()
#542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a cosmetic change since the dialyzer isn't smart enough yet to
notice the mixup. With the addition of nominal types in OTP 28 though we
will eventually be able to get the dialyzer to notice this.
Note that in practice `#request_vote_rpc{}` and `#pre_vote_rpc{}` are
being constructed correctly with `ra_term()`s in these fields, so this
isn't a bug fix.
michaelklishin
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cosmetic change since the dialyzer isn't smart enough yet to notice the mixup. With the addition of nominal types in OTP 28 though we will eventually be able to get the dialyzer to notice this. I played around with nominal types on OTP 28 in this branch and the dialyzer found these mixups.
Note that in practice
#request_vote_rpc{}and#pre_vote_rpc{}are being constructed correctly withra_term()s in these fields, so this isn't a bug fix.