oggopus: provide a bitrate property#704
Merged
lazka merged 1 commit intoquodlibet:mainfrom Feb 15, 2026
Merged
Conversation
Estimate the bitrate based on the file size when seeking after the tag pages. This makes sure the bitrate doesn't change when changing the tags. Fixes quodlibet#475
phw
approved these changes
Feb 15, 2026
Collaborator
phw
left a comment
There was a problem hiding this comment.
Looks good to me. I agree with your comment on #475 . There is a limit what mutagen, as a metadata library, should do to get this data. Full audio parsing should not be the goal.
We have other formats where both length and bitrate can be an approximation based on data size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estimate the bitrate based on the file size when seeking after the tag pages. This makes sure the bitrate doesn't change when changing the tags.
Fixes #475