Open
Conversation
quarkus-bot
bot
added
area/docstyle
This comment has been minimized.
This comment has been minimized.
|
🎊 PR Preview c4331c7 has been successfully built and deployed to https://quarkus-pr-main-52934-preview.surge.sh/version/main/guides/
|
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
MichalMaler
force-pushed
the
Review-of-the-logging-guide
branch
from
0951751 to
a5fd438
Compare
MichalMaler
commented
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
Ladicek
reviewed
Mar 6, 2026
This comment has been minimized.
This comment has been minimized.
MichalMaler
force-pushed
the
Review-of-the-logging-guide
branch
from
a5fd438 to
c9e83d8
Compare
Contributor
Author
|
@Ladicek Thank you so much for the great review and cooperation! |
This comment has been minimized.
This comment has been minimized.
dmlloyd
reviewed
Mar 6, 2026
Member
dmlloyd
left a comment
dmlloyd
left a comment
There was a problem hiding this comment.
Overall LGTM with one small comment.
MichalMaler
force-pushed
the
Review-of-the-logging-guide
branch
from
c9e83d8 to
4472a4e
Compare
MichalMaler
added
triage/backport-3.32
triage/waiting-for-ci
Contributor
Author
MichalMaler
removed
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
dmlloyd
approved these changes
Mar 9, 2026
sheilamjones
reviewed
Mar 9, 2026
sheilamjones
reviewed
Mar 9, 2026
Contributor
sheilamjones
left a comment
sheilamjones
left a comment
There was a problem hiding this comment.
Hi @MichalMaler,
Looks great @MichalMaler. I had some minor edits for your consideration, but nothing urgent.
Thanks,
Sheila
Applying feedback from the Ladislav Thon's review Sheila Jone's review Signed-off-by: Michal Maléř <mmaler@redhat.com>
MichalMaler
force-pushed
the
Review-of-the-logging-guide
branch
from
4472a4e to
68d35eb
Compare
MichalMaler
added
the
triage/waiting-for-ci
Status for workflow
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes a sanity check and small wording fixes across the Logging guide.
The final version is always the result of communication with an SME.
These fixes need to be backported to a branch from which RHBQ and IBMbQ 3.33 docs are about to be built.