Skip to content

consolidate spotless-maven-plugin, formatter-maven-plugin, and impsort-maven-plugin #48394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

consolidate spotless-maven-plugin, formatter-maven-plugin, and impsort-maven-plugin #48394

wants to merge 1 commit into from

Conversation

Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Jun 15, 2025 •
edited
Loading

fix:

[INFO] Quarkus - Integration Tests - Virtual Threads - JMS  SUCCESS [  0.031 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Vert.x Event Bus SUCCESS [  0.036 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Scheduler SUCCESS [  0.039 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Quartz Scheduler SUCCESS [  0.036 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Disabled SUCCESS [  0.037 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Reactive Routes SUCCESS [  0.032 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Security WebAuthn SUCCESS [  0.031 s]
[INFO] Quarkus - Integration Tests - Virtual Threads - Micrometer Metrics SUCCESS [  0.030 s]
[INFO] Quarkus - Integration Tests - Mutiny native JCTools support SUCCESS [  0.038 s]
[INFO] Quarkus - Documentation ............................ SUCCESS [  0.363 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:20 min
[INFO] Finished at: 2025-06-15T17:46:10+02:00
[INFO] ------------------------------------------------------------------------
[INFO] Njord session closed
[INFO] 1296 goals, 1296 executed
[WARNING] 
[WARNING] 1 build scan custom value was not captured:
[WARNING]  - Maximum custom value value length (100.000) exceeded: Git status
➜  quarkus git:(spot-missing-override) ✗ mvn spotless:apply

Pankraz76
Pankraz76 commented Jun 15, 2025
View reviewed changes
...rojects/bootstrap/runner/src/main/java/io/quarkus/bootstrap/logging/InitialConfigurator.java Outdated
return new Handler[] {
createDefaultHandler()
};
return new Handler[] { createDefaultHandler() };
Copy link
Author

@Pankraz76 Pankraz76 Jun 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline seems good.

Pankraz76
Pankraz76 commented Jun 15, 2025
View reviewed changes
...ootstrap/runner/src/main/java/io/quarkus/bootstrap/naming/DisabledInitialContextManager.java Outdated
* {@link NamingManager#setInitialContextFactoryBuilder(InitialContextFactoryBuilder) cannot be replaced}
* and will never get garbage-collected due to being referenced from a sticky class ({@link NamingManager}),
* so its classloader will never get garbage-collected either.
* {@link NamingManager#setInitialContextFactoryBuilder(InitialContextFactoryBuilder) cannot be replaced} and will never
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does use full length "128" now.

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/codestarts area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/elasticsearch area/gradle Gradle area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jbang Issues related to when using jbang.dev with Quarkus area/kubernetes area/maven area/panache area/platform Issues related to definition and interaction with Quarkus Platform area/redis area/rest area/vertx labels Jun 15, 2025
@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 15, 2025

/cc @gsmet (elasticsearch), @loicmathieu (elasticsearch), @marko-bekhta (elasticsearch)

@quarkus-bot quarkus-bot
Copy link

quarkus-bot bot commented Jun 15, 2025

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@Pankraz76
Copy link
Author

@gsmet @gastaldi
please see demo of format delta. spot does interprete the eclipse config differently.

current setup does not fix unused imports due to bug in plugin.

spot covered other two plugins making it 3 for 1 tradeoff as spot is already integrated but not in used, this an cost of carry issue itself.

please lets work together. sorry for overpacing i need to coordinate better. its my hyper activity.

having guidance from you we can leverage this and make the code better.

please see that my suggestions can be used for good. i have no problem of a closed pr. we make better version every time.

its no thing to rush of course.

@Pankraz76 Pankraz76 changed the title use spotless as root formatter tradeoff 3 for 1 plugins consolidate root config for spotless-maven-plugin, formatter-maven-plugin and impsort-maven-plugin Jun 15, 2025
@Pankraz76 Pankraz76 changed the title consolidate root config for spotless-maven-plugin, formatter-maven-plugin and impsort-maven-plugin consolidate root for spotless-maven-plugin, formatter-maven-plugin and impsort-maven-plugin Jun 15, 2025
@Pankraz76
Copy link
Author

should it be same version?

image

@Pankraz76 Pankraz76 force-pushed the spot-missing-override branch from 7f613dc to cf60bdf Compare June 15, 2025 16:26
Pankraz76
Pankraz76 commented Jun 15, 2025
View reviewed changes
extensions/websockets-next/deployment/pom.xml
@@ -196,8 +196,7 @@
<properties>
<maven.compiler.target>21</maven.compiler.target>
<maven.compiler.source>21</maven.compiler.source>
<!-- javaparser 3.25.10 used by impsort-maven-plugin does not define the "language level" for 21 -->
<!--maven.compiler.release>21</maven.compiler.release-->
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a win.

@geoand
@gastaldi
@gsmet

@Pankraz76 Pankraz76 force-pushed the spot-missing-override branch from cf60bdf to b9b3cd3 Compare June 15, 2025 16:29
Pankraz76
Pankraz76 commented Jun 15, 2025
View reviewed changes
build-parent/pom.xml

<profile>
<id>format-kotlin</id>
Copy link
Author

@Pankraz76 Pankraz76 Jun 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems lost.

image

@Pankraz76 Pankraz76 force-pushed the spot-missing-override branch from b9b3cd3 to d7ba9bc Compare June 15, 2025 16:31
Pankraz76
Pankraz76 commented Jun 15, 2025
View reviewed changes
independent-projects/parent/pom.xml
<!-- store outside of target to speed up formatting when mvn clean is used -->
<cachedir>.cache/formatter-maven-plugin-${version.formatter.plugin}</cachedir>
<configFile>eclipse-format.xml</configFile>
<lineEnding>LF</lineEnding>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not applied!

independent-projects/parent/pom.xml
<formats>
<format>
<trimTrailingWhitespace/>
<endWithNewline/>
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will!

independent-projects/parent/pom.xml
<importOrder>
<file>${maven.multiModuleProjectDirectory}/independent-projects/ide-config/src/main/resources/eclipse.importorder</file>
</importOrder>
<removeUnusedImports />
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes leftovers:

@Pankraz76 Pankraz76 changed the title consolidate root for spotless-maven-plugin, formatter-maven-plugin and impsort-maven-plugin consolidate spotless-maven-plugin, formatter-maven-plugin and impsort-maven-plugin Jun 15, 2025
@Pankraz76 Pankraz76 changed the title consolidate spotless-maven-plugin, formatter-maven-plugin and impsort-maven-plugin consolidate spotless-maven-plugin, formatter-maven-plugin, and impsort-maven-plugin Jun 15, 2025
@Pankraz76 Pankraz76 marked this pull request as ready for review June 15, 2025 16:36
@Pankraz76
Copy link
Author

Pankraz76 commented Jun 15, 2025 •
edited
Loading

if you like then, need to execute local as (almost) EVERYTHING will be changed ONCE, and be fixed, like aimed before, but this time done and dusty.

@Pankraz76 Pankraz76 marked this pull request as draft June 18, 2025 13:23
@Pankraz76
Copy link
Author

quarkus dont care

@Pankraz76 Pankraz76 closed this Jun 20, 2025
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/arc Issue related to ARC (dependency injection) area/codestarts area/dependencies Pull requests that update a dependency file area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/elasticsearch area/gradle Gradle area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/jbang Issues related to when using jbang.dev with Quarkus area/kubernetes area/maven area/panache area/platform Issues related to definition and interaction with Quarkus Platform area/redis area/rest area/vertx triage/invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Pankraz76