feat: add IterateColumns method for improved performance#2196
Open
DengY11 wants to merge 3 commits intoqax-os:masterfrom
Open
feat: add IterateColumns method for improved performance#2196DengY11 wants to merge 3 commits intoqax-os:masterfrom
DengY11 wants to merge 3 commits intoqax-os:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2196 +/- ##
==========================================
- Coverage 99.24% 99.14% -0.10%
==========================================
Files 32 32
Lines 30562 30626 +64
==========================================
+ Hits 30331 30365 +34
- Misses 153 175 +22
- Partials 78 86 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
added 2 commits
August 7, 2025 14:21
|
Is this pr still adding? Wish to add the feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Add rows.IterateColumns(iterateFunc), iterate it with a callback function instead create a huge []string.And that will enhance memory performance
Related Issue
close #2191
Example:
How Has This Been Tested
go test
Types of changes
Checklist