Conversation
79958aa to
0c3dfb1
Compare
|
Hello, is there any problem with this pull request or maybe you planned such a function ? |
|
Hi @xuri, Is there an issue with the changes suggested ? It blocks the following issue: go-mods/excel#1 Thank you in advance, |
xuri
left a comment
There was a problem hiding this comment.
Thanks for your pull request. Sorry for my late reply.
We needn't provide a sets of function for each properties of table, such ReSizeTable, RenameTable, ReStyleTable, etc., change AddTable to SetTable would be better approch, create table if table not exist, overwise update specified properties of table for the table: Range, Name, StyleName, etc., but this is a breaking changes, and we also need added SourceName and TargetName in the Table data type.
This library already support get table definiation and add table. Due to the principle of minimum availability, there is no plan to introduce new similar functions to keep the library core and easy.
PR Details
Add function
ResizeTableto resize a table instead of deleting and adding a tableDescription
Related Issue
Motivation and Context
It seems easier to resize a table when needed instead of deleting the table and re-adding it
How Has This Been Tested
I added the unit test for the methods I created.
I ran all the tests locally.
Types of changes
Checklist