Skip to content

Fix automatic upload of new releases#240

Merged
mraspaud merged 1 commit intopytroll:mainfrom
mraspaud:fix_deploy
Sep 15, 2025
Merged

Fix automatic upload of new releases#240
mraspaud merged 1 commit intopytroll:mainfrom
mraspaud:fix_deploy

Conversation

@mraspaud
Copy link
Copy Markdown
Member

@mraspaud mraspaud commented Sep 12, 2025

Release of 0.17 automatic upload did not go through sdist since setup.py was removed.

@mraspaud mraspaud requested a review from pnuu as a code owner September 12, 2025 11:07
@mraspaud mraspaud self-assigned this Sep 12, 2025
@mraspaud mraspaud added the bug Something isn't working label Sep 12, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.81%. Comparing base (5237dab) to head (dfa53b4).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #240   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          15       15           
  Lines        3373     3373           
=======================================
  Hits         3198     3198           
  Misses        175      175           
Flag Coverage Δ
unittests 94.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂️ I should have caught this.

@mraspaud
Copy link
Copy Markdown
Member Author

🤦‍♂️ I should have caught this.

No worries.

For the record, I uploaded the dist packages manually, so there is no rush in making a new release.

@mraspaud mraspaud merged commit 4c880c0 into pytroll:main Sep 15, 2025
10 checks passed
@mraspaud mraspaud deleted the fix_deploy branch September 15, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants